From owner-cvs-bin Thu Jun 19 10:56:46 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id KAA08471 for cvs-bin-outgoing; Thu, 19 Jun 1997 10:56:46 -0700 (PDT) Received: from time.cdrom.com (root@time.cdrom.com [204.216.27.226]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA08454; Thu, 19 Jun 1997 10:56:31 -0700 (PDT) Received: from time.cdrom.com (jkh@localhost.cdrom.com [127.0.0.1]) by time.cdrom.com (8.8.5/8.6.9) with ESMTP id KAA23921; Thu, 19 Jun 1997 10:56:12 -0700 (PDT) To: Bruce Evans cc: cvs-all@FreeBSD.ORG, cvs-bin@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, jkh@FreeBSD.ORG Subject: Re: cvs commit: src/bin/sh expand.c In-reply-to: Your message of "Fri, 20 Jun 1997 01:30:14 +1000." <199706191530.BAA13078@godzilla.zeta.org.au> Date: Thu, 19 Jun 1997 10:56:12 -0700 Message-ID: <23917.866742972@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-bin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > The submitted patch misses the point and should never have been committed. C'mon, Bruce, don't beat around the bush - what are you trying to say? :-) > See followup mail in the PR about what the problem actually is. OK, sorry, I missed this somehow. > Submitted patches are almost never suitable for committing directly. Well, I did look at it first, sheesh! ;) Given the mastications that sh was doing on the value of the integer there, the fix seemed perfectly correct so I committed it. I didn't know I was walking into a POSIX war in the process, the kind where you generally tend to note 27 different things which are wrong in copious detail and thus scare everyone away from actually trying to treat the affected areas. :-) Been there, done that already, am backing out the change right now. :) Jordan