From owner-svn-src-all@FreeBSD.ORG  Tue Nov 20 05:49:18 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 5C3AF33D;
 Tue, 20 Nov 2012 05:49:18 +0000 (UTC)
 (envelope-from mike.telahun@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
 [209.85.214.54])
 by mx1.freebsd.org (Postfix) with ESMTP id 4E65E8FC14;
 Tue, 20 Nov 2012 05:49:17 +0000 (UTC)
Received: by mail-bk0-f54.google.com with SMTP id je9so1556890bkc.13
 for <multiple recipients>; Mon, 19 Nov 2012 21:49:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=message-id:date:from:user-agent:mime-version:to:cc:subject
 :references:in-reply-to:content-type:content-transfer-encoding;
 bh=icqdCOqmJdzxuUZCsCtwHrojJ3Pdg6uHV8ZkdTYmwQA=;
 b=SUuN/Wtaae0UShmLjSMA/M8uF0/+wW3Tlxht/CSQ1kWdLgkyOq+cloLuGXLLBWOduD
 9C2lro6+z67Zdtm3asZV/EVIEF+z1kqBgePHupMsduT6MjEmYrgejWzJTYfl/QZwMoXG
 nQxWQp4/DaCmclb/NaXRUMnPulB0BZQGRbBF/j2dQMjtm++txPIjo81fh8OLcCplDHv4
 KzKjVh3USkeTvOjhs4wCblVUbK6qviWMH8x3tLTFdtnR5IWddUQtBWiEYH8bO/tYGCj2
 2f4JmhrjSR3Rye+aBzaf2NO+eVuwbu/iKIEDUzVleRuyBcpni6I823UBi2N53yeqNMo3
 WlxA==
Received: by 10.204.11.70 with SMTP id s6mr5754011bks.63.1353390555346;
 Mon, 19 Nov 2012 21:49:15 -0800 (PST)
Received: from [172.16.16.143] ([213.55.76.19])
 by mx.google.com with ESMTPS id f24sm3208239bkv.7.2012.11.19.21.49.11
 (version=SSLv3 cipher=OTHER); Mon, 19 Nov 2012 21:49:14 -0800 (PST)
Message-ID: <50AB19D3.9080106@gmail.com>
Date: Tue, 20 Nov 2012 08:49:07 +0300
From: Mike Telahun <mike.telahun@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux i686;
 rv:16.0) Gecko/20121028 Thunderbird/16.0.2
MIME-Version: 1.0
To: Hiroki Sato <hrs@FreeBSD.org>
Subject: Re: svn commit: r243324 - head/etc
References: <201211200445.qAK4j4YF027280@svn.freebsd.org>
In-Reply-To: <201211200445.qAK4j4YF027280@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Nov 2012 05:49:18 -0000

> @@ -704,7 +704,10 @@ run_rc_command()
>  
>  		start)
>  			if [ -z "$rc_fast" -a -n "$rc_pid" ]; then
> -				echo 1>&2 "${name} already running? (pid=$rc_pid)."
> +				if [ -z "$rc_quiet" ]; then

Shouldn't this be using checkyesno() ?
What happens if someone has rc_quiet=NO in /etc/rc.conf?

> +					echo 1>&2 "${name} already running? " \
> +					    "(pid=$rc_pid)."
> +				fi
>  				return 1
>  			fi
>  
> 

Cheers,
Mike.