Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Apr 2022 00:03:55 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 08ff11e52423 - main - tpm: Remove unused variables.
Message-ID:  <202204080003.23803t5F086997@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by jhb:

URL: https://cgit.FreeBSD.org/src/commit/?id=08ff11e524230bf9bf4c2adfd8f094af64c5f956

commit 08ff11e524230bf9bf4c2adfd8f094af64c5f956
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-08 00:01:29 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-04-08 00:01:29 +0000

    tpm: Remove unused variables.
    
    All of the legacy config stuff in tpm seems broken.  Nothing ever sets
    tpm_enabled to a non-zero value and the legacy bits expect tpm_enabled
    to be set to the base IO port address (I think).
---
 sys/dev/tpm/tpm.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sys/dev/tpm/tpm.c b/sys/dev/tpm/tpm.c
index 21d68012aded..0a041fa96114 100644
--- a/sys/dev/tpm/tpm.c
+++ b/sys/dev/tpm/tpm.c
@@ -1018,7 +1018,6 @@ int
 tpm_legacy_init(struct tpm_softc *sc, int irq, const char *name)
 {
 	char id[8];
-	u_int8_t ioh, iol;
 	int i;
 
 	if ((i = bus_space_map(sc->sc_batm, tpm_enabled, 2, 0, &sc->sc_bahm))) {
@@ -1031,8 +1030,6 @@ tpm_legacy_init(struct tpm_softc *sc, int irq, const char *name)
 		id[i] = tpm_legacy_in(sc->sc_bt, sc->sc_bh, TPM_ID + i);
 
 	printf(": %.4s %d.%d @0x%x\n", &id[4], id[0], id[1], tpm_enabled);
-	iol = tpm_enabled & 0xff;
-	ioh = tpm_enabled >> 16;
 	tpm_enabled = 0;
 
 	return 0;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202204080003.23803t5F086997>