Date: Thu, 30 Dec 2004 20:55:35 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Cc: geom@freebsd.org Subject: Re: GEOM_VOL panics when audio CD is present Message-ID: <47392.1104436535@critter.freebsd.dk> In-Reply-To: Your message of "Thu, 30 Dec 2004 20:45:22 %2B0100." <xzpoegbvact.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <xzpoegbvact.fsf@dwp.des.no>, =?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?= writes: >"Poul-Henning Kamp" <phk@phk.freebsd.dk> writes: >> I think the right check is to make sure the sectorsize is a power >> of two && > DEV_BSIZE. > >Not good enough. The panic will still be triggered by providers with >a sector size larger than 8192 (which is the smallest non-zero offset >g_vol_ffs_taste() tries to use). The fact that no such devices exist >today does not mean they won't exist at some point in the not-so- >distant future. You're right, we need to check for that too. They could exist with gbde btw. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47392.1104436535>