Date: Fri, 14 Dec 2001 03:13:46 +0000 From: Dima Dorfman <dima@trit.org> To: Robert Watson <rwatson@freebsd.org> Cc: "Brian F. Feldman" <green@freebsd.org>, arch@freebsd.org Subject: Re: MFC'ing xucred definition Message-ID: <20011214031351.6D1203E2F@bazooka.trit.org> In-Reply-To: <Pine.NEB.3.96L.1011213220002.74588E-100000@fledge.watson.org>; from rwatson@freebsd.org on "Thu, 13 Dec 2001 22:02:42 -0500 (EST)"
next in thread | previous in thread | raw e-mail | index | archive | help
Robert Watson <rwatson@freebsd.org> wrote: > > On Fri, 14 Dec 2001, Dima Dorfman wrote: > > > I'm sure there was a reason I named it cr_xversion, but I can't remember > > it now :-/. I've made both of these changes; you can find the new patch > > at http://www.trit.org/~dima/home/a/crxver.diff (I'm not posting it > > since there's nothing terribly interesting in it compared to the old > > one). > > > > Barring any objections, I plan to commit it this weekend, and MFC the > > xucred definition, along with my LOCAL_PEERCRED changes, some time > > before the 4.5 freeze. > > Actually, the one thing I'd like to see before we move forward is a > standard routine that accepts a ucred, and a *xucred, and fills out the > xucred using the ucred (preferably, in kern_prot.c). Right now, xucred is > filled out in various places manually (netinet, socket code, et al). As > we begin to broaden the scope of xucred (for example, I'd like to push in > the ruid and rgid), it will make things a lot easier, and also prevent > more code from knowing much about the innards of ucred. That way, also, > the version number can be kept in one place. I had patches to add this routine (and vice versa, xucred->ucred) before you added the extra fields to ucred, at which point I dropped it since it didn't make much sense: Which fields do you copy? Effective, real, or saved {u,g}ids? It would again make sense if xucred had the same set of fields as ucred, however. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011214031351.6D1203E2F>