From owner-freebsd-bugs@FreeBSD.ORG Thu Mar 10 16:30:09 2005 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8581716A4CE for ; Thu, 10 Mar 2005 16:30:09 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E18443D41 for ; Thu, 10 Mar 2005 16:30:09 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j2AGU9CW067428 for ; Thu, 10 Mar 2005 16:30:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j2AGU9hi067427; Thu, 10 Mar 2005 16:30:09 GMT (envelope-from gnats) Resent-Date: Thu, 10 Mar 2005 16:30:09 GMT Resent-Message-Id: <200503101630.j2AGU9hi067427@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Cyril Vechera Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C0A5816A4CE for ; Thu, 10 Mar 2005 16:29:57 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id A2C0443D41 for ; Thu, 10 Mar 2005 16:29:57 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j2AGTrlI020390 for ; Thu, 10 Mar 2005 16:29:53 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id j2AGTrFo020389; Thu, 10 Mar 2005 16:29:53 GMT (envelope-from nobody) Message-Id: <200503101629.j2AGTrFo020389@www.freebsd.org> Date: Thu, 10 Mar 2005 16:29:53 GMT From: Cyril Vechera To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: kern/78673: nfs client open resets attrstamp ever if fs is mounted readonly X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2005 16:30:09 -0000 >Number: 78673 >Category: kern >Synopsis: nfs client open resets attrstamp ever if fs is mounted readonly >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Mar 10 16:30:08 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Cyril Vechera >Release: 5-STABLE >Organization: Net Ltd. >Environment: FreeBSD cv.ws.local 5.3-RELEASE-p5 FreeBSD 5.3-RELEASE-p5 #1: Thu Mar 10 13:32:50 UTC 2005 root@compiler.incru.net:/usr/src/sys/i386/compile/OFFICIER i386 >Description: NFS client resets the timestamp of a cached attributes on each open call. When the file system is mounted read only it couses unnecessary request to the NFS server to get fresh access attributes. >How-To-Repeat: >Fix: patch attached: *** /usr/src/sys/nfsclient/nfs_vnops.c.orig Thu Mar 10 22:23:03 2005 --- /usr/src/sys/nfsclient/nfs_vnops.c Thu Mar 10 00:33:51 2005 *************** *** 463,469 **** np->n_mtime = vattr.va_mtime.tv_sec; } } ! np->n_attrstamp = 0; /* For Open/Close consistency */ return (0); } --- 463,470 ---- np->n_mtime = vattr.va_mtime.tv_sec; } } ! if (!(vp->v_mount->mnt_flag & MNT_RDONLY)) ! np->n_attrstamp = 0; /* For Open/Close consistency */ return (0); } >Release-Note: >Audit-Trail: >Unformatted: