From owner-svn-src-head@freebsd.org Wed Jan 4 04:19:06 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5785BC9EF85; Wed, 4 Jan 2017 04:19:06 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 26348172C; Wed, 4 Jan 2017 04:19:06 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v044J5NR076273; Wed, 4 Jan 2017 04:19:05 GMT (envelope-from ngie@FreeBSD.org) Received: (from ngie@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v044J5DO076272; Wed, 4 Jan 2017 04:19:05 GMT (envelope-from ngie@FreeBSD.org) Message-Id: <201701040419.v044J5DO076272@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: ngie set sender to ngie@FreeBSD.org using -f From: Ngie Cooper Date: Wed, 4 Jan 2017 04:19:05 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r311245 - head/contrib/netbsd-tests/lib/libc/ttyio X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 04:19:06 -0000 Author: ngie Date: Wed Jan 4 04:19:05 2017 New Revision: 311245 URL: https://svnweb.freebsd.org/changeset/base/311245 Log: tty: don't leak s after opening it with openpty MFC after: 3 days Reported by: Coverity CID: 978321 Modified: head/contrib/netbsd-tests/lib/libc/ttyio/t_ttyio.c Modified: head/contrib/netbsd-tests/lib/libc/ttyio/t_ttyio.c ============================================================================== --- head/contrib/netbsd-tests/lib/libc/ttyio/t_ttyio.c Wed Jan 4 04:10:36 2017 (r311244) +++ head/contrib/netbsd-tests/lib/libc/ttyio/t_ttyio.c Wed Jan 4 04:19:05 2017 (r311245) @@ -152,6 +152,9 @@ ATF_TC_BODY(ioctl, tc) REQUIRE_ERRNO(sigaction(SIGCHLD, &sa, NULL), -1); (void) wait(NULL); +#ifdef __FreeBSD__ + (void)close(s); +#endif ATF_REQUIRE_EQ(rc, 0); }