From owner-cvs-src@FreeBSD.ORG Fri Jun 6 14:28:41 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 47EFD106567D; Fri, 6 Jun 2008 14:28:41 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 10A3D8FC19; Fri, 6 Jun 2008 14:28:40 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m56EPgXv045214; Fri, 6 Jun 2008 08:25:42 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 06 Jun 2008 08:27:06 -0600 (MDT) Message-Id: <20080606.082706.-345494353.imp@bsdimp.com> To: sobomax@freebsd.org From: "M. Warner Losh" In-Reply-To: <4846F30A.5070204@FreeBSD.org> References: <20080604192955.GA46284@troutmask.apl.washington.edu> <4846EF10.1020803@FreeBSD.org> <4846F30A.5070204@FreeBSD.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 06 Jun 2008 14:41:22 +0000 Cc: danfe@freebsd.org, src-committers@freebsd.org, flz@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, sgk@troutmask.apl.washington.edu, wb@freebie.xs4all.nl, remko@freebsd.org, cokane@freebsd.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/add main.c pkg_add.1 src/usr.sbin/pkg_install/create main.c pkg_create.1 src/usr.sbin/pkg_install/delete main.c pkg_delete.1 src/usr.sbin/pkg_install/info main.c pkg_info.1 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jun 2008 14:28:41 -0000 : It's not your call either. We have style(9), which says: Thus quote he from the holy book of style, section nine, verses 127-134 : For consistency, getopt(3) should be used to parse options. Options : should be sorted in the getopt(3) call and the switch statement, : unless : parts of the switch cascade. Elements in a switch statement that : cascade : should have a FALLTHROUGH comment. Numerical arguments should be : checked : for accuracy. Code that cannot be reached should have a : NOTREACHED com- : ment. : : There is nothing about getopt_long(3) being acceptable : replacement/addition to the getopt(3). Style(9) is about documenting the normative style of the project. While we prefer people to use it, it isn't religious dogma. getopt_long() is in the spirit of style(9) which is trying to say "don't be a dumb-ass and write your own argument parsing routine." Warner