Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 7 Apr 2022 17:18:56 -0700
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 0c348b97eb05 - main - zfs: Disable -Wunused-but-set-variable for a few files in zstd.
Message-ID:  <6ab36d24-b934-d835-1256-dcbcbab44e60@FreeBSD.org>
In-Reply-To: <202204080004.238043GV087171@gitrepo.freebsd.org>
References:  <202204080004.238043GV087171@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 4/7/22 5:04 PM, John Baldwin wrote:
> The branch main has been updated by jhb:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=0c348b97eb051b22f3ee956f17c332eaacb63d59
> 
> commit 0c348b97eb051b22f3ee956f17c332eaacb63d59
> Author:     John Baldwin <jhb@FreeBSD.org>
> AuthorDate: 2022-04-08 00:01:29 +0000
> Commit:     John Baldwin <jhb@FreeBSD.org>
> CommitDate: 2022-04-08 00:01:29 +0000
> 
>      zfs: Disable -Wunused-but-set-variable for a few files in zstd.
>      
>      FSE_createCTable raises the warning because we stub out malloc() to
>      NULL in the kernel, so the passed in size is unused.
>      
>      ZSTD_seqDecompressedSize has a variable whose value is only used in
>      assertions.
>      
>      NB: These files are missing corresponding entries in sys/conf/files.

I still have a few less trivial patches in review, but with those I'm now
able to build an amd64 GENERIC with the -Wunused-but-set-variable left as
an error.  I'll try to take some other arches (i386 and arm64) as well as
LINT next.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6ab36d24-b934-d835-1256-dcbcbab44e60>