From owner-svn-src-head@FreeBSD.ORG Mon Oct 22 13:33:45 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D6A29AE5; Mon, 22 Oct 2012 13:33:45 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id A385B8FC16; Mon, 22 Oct 2012 13:33:45 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id E7F0DB96C; Mon, 22 Oct 2012 09:33:44 -0400 (EDT) From: John Baldwin To: Eitan Adler Subject: Re: svn commit: r241856 - in head/sys: arm/xscale/pxa dev/acpica dev/agp dev/amdsbwd dev/amdtemp dev/asmc dev/coretemp dev/e1000 dev/glxiic dev/ixgbe dev/kbdmux dev/sound/pci i386/acpica i386/bios x86/... Date: Mon, 22 Oct 2012 09:33:29 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p20; KDE/4.5.5; amd64; ; ) References: <201210220341.q9M3fEdu023999@svn.freebsd.org> <201210220842.31106.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201210220933.29998.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 22 Oct 2012 09:33:45 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2012 13:33:45 -0000 On Monday, October 22, 2012 9:03:50 am Eitan Adler wrote: > On 22 October 2012 08:42, John Baldwin wrote: > > On Sunday, October 21, 2012 11:41:14 pm Eitan Adler wrote: > >> Author: eadler > >> Date: Mon Oct 22 03:41:14 2012 > >> New Revision: 241856 > >> URL: http://svn.freebsd.org/changeset/base/241856 > >> > >> Log: > >> Now that device disabling is generic, remove extraneous code from the > >> device drivers that used to provide this feature. > > > > This isn't functionally identical. In some cases a hint to disable > > unit 0 would in fact disable all units. For example, disabling est0 and > > acpi_perf0 disabled all instances of estX and acpi_perfX, not just the > > first one. You should test this on a multi-CPU machine before and after > > to see the different effects. > > > > The one in the x86 code that handles early mapping of ACPI tables before > > new-bus is around is also very important (acpi_find_table()). You just > > broke booting on SMP systems where ACPI is disabled but that contain an > > MADT for example (pretty much all modern x86 SMP systems). > > > > elcr is also not a new-bus device, so removing that hint broke that > > psuedo-driver as well. > > > > It is only safe to remove these calls in new-bus attach (not probe!) > > routines that are using 'device_get_unit()' and not hardcoding the > > unit to 0 (unless you know for certain that there can only ever be one > > instance of this device such as acpi0 or asmc0). > > Thanks for the information. I will revert and come up with a better patch. I don't think you need to revert all of them. Just go back over your patch and revert the ones that aren't definitely safe. I think the ones I included in my first e-mail are the ones you need to revert, but I haven't double checked that list. -- John Baldwin