Date: Sun, 28 Sep 2008 13:58:59 -0700 From: Xin LI <delphij@delphij.net> To: Kostik Belousov <kostikbel@gmail.com> Cc: Xin LI <delphij@FreeBSD.ORG>, src-committers@FreeBSD.ORG, d@delphij.net, cvs-all@FreeBSD.ORG, cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/init init.c Message-ID: <48DFF013.3080309@delphij.net> In-Reply-To: <20080928203210.GA2433@deviant.kiev.zoral.com.ua> References: <200809270009.m8R09OTF000738@repoman.freebsd.org> <20080927084606.GZ47828@deviant.kiev.zoral.com.ua> <48DFE13E.2030200@delphij.net> <20080928203210.GA2433@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Kostik Belousov wrote: > On Sun, Sep 28, 2008 at 12:55:42PM -0700, Xin LI wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Kostik Belousov wrote: >>> On Sat, Sep 27, 2008 at 12:09:10AM +0000, Xin LI wrote: >>>> delphij 2008-09-27 00:09:10 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sbin/init init.c >>>> Log: >>>> SVN rev 183391 on 2008-09-27 00:09:10Z by delphij >>>> >>>> Static-ify procedures in init(8). >>>> >>>> Revision Changes Path >>>> 1.66 +79 -79 src/sbin/init/init.c >>> What is a reason for the change ? >> This would reduce the size of generated binary... > > I am quite curious. Could you, please, show the numbers. > Is the reduction in size is due to function inlining, or it is purely > symbol table size issue ? Oh it's not purely symbol table size, making these stuff static would reduce instructions by 100+ for this case. If we strip all symbols out then we still have a 2KB saving by doing this. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkjf8BMACgkQi+vbBBjt66B1nwCffDVNCGXBm6cqWwfcyrUSvbMA NgwAnijd7Ya4k3MmiuH7VhDyh9KmPMhc =K5Hc -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48DFF013.3080309>