From owner-cvs-all@FreeBSD.ORG Mon Feb 14 04:03:49 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6203F16A4CE; Mon, 14 Feb 2005 04:03:49 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 398E743D41; Mon, 14 Feb 2005 04:03:49 +0000 (GMT) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id 2A7AF5C99B; Sun, 13 Feb 2005 20:03:49 -0800 (PST) Date: Mon, 14 Feb 2005 05:03:49 +0100 From: Maxime Henrion To: Joe Marcus Clarke Message-ID: <20050214040349.GA61763@elvis.mu.org> References: <200502131838.j1DIc6tZ020690@repoman.freebsd.org> <1108337583.93267.1.camel@shumai.marcuscom.com> <20050214020531.GD40468@funkthat.com> <1108352249.93267.20.camel@shumai.marcuscom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1108352249.93267.20.camel@shumai.marcuscom.com> User-Agent: Mutt/1.4.2.1i cc: Daniel Eischen cc: cvs-src@freebsd.org cc: John-Mark Gurney cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_attr_init.c thr_init.c thr_private.h thr_stack.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2005 04:03:49 -0000 Joe Marcus Clarke wrote: > On Sun, 2005-02-13 at 18:05 -0800, John-Mark Gurney wrote: > > Joe Marcus Clarke wrote this message on Sun, Feb 13, 2005 at 18:33 -0500: > > > And there was much rejoicing! I would like to reiterate mezz's request > > > for a __FreeBSD_version bump once all the thread libraries are updated. > > > It would also be good to get this MFC'd before 5.4. Thanks again. > > > > If any application that cares/requires changes from the default, either > > due to large number of threads (requiring small stack size), or large > > stacks, should already be patched with their new defaults... So > > requiring a modification based upon version before/after this change > > should be unnecessary... > > But knowing when this patch is implemented means we can _not_ patch > certain applications. The best example of this is gstreamer. Gstreamer > is patched to lower its initial thread stack usage to 1 MB since that > was the previous limit. This severely limits gstreamer. With the > larger initial thread stack size (something that is not changeable by > individual applications), we no longer need to cripple gstreamer on > -CURRENT. Therefore, I ask __FreeBSD_version to be bumped so I know > when it's safe to let gstreamer take a full 2 MB of stack on the initial > thread. Is there anything wrong with pthread_attr_setstacksize()? Using this to patch the said applications would allow them to get an acceptably sized stack whether the host is running an old or a recent version of libpthread. It would also make sense to then submit the patches to the vendor so that it's not too much a burden to maintain. Cheers, Maxime