From nobody Fri Apr 8 01:40:33 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E5E851A87F25; Fri, 8 Apr 2022 01:40:36 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KZLYJ6FbWz3JNX; Fri, 8 Apr 2022 01:40:36 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649382036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wsSWcR7P3jp1Sx8Td6c01YOB929UD10xkWfNDWBMPf0=; b=EgO1hhddne54+wKcF2oD1dh76OYNjwhNGslf0/rwC1+le6xWCkHbc4vI80b7rWG0Y0vsHx KwIsLqvp5x5IjVVq909EHGSlempcGtnql63XxEdNZr34a7YdVFi25qHglHnVA9qChXMjyM hh3q37SZ+G4ZCX/pezEJw5XPI3/edtPSocCxM6Hy3YsEImAc5YACbzSD4NjnSKwa58X3ai cS5hN+dZ9hAF4pmE5K9mZHs6DP64zDwzTdKBVGZZYm5TlNhI+NBtkzUqTk48wY+c51N0xo ao5VMhJz8EXb66OKeQKrvYlg00Iy3+4RAG6T33OSLrRaVoYvH1xVS88v5Z2m8g== Received: from [192.168.1.10] (unknown [IPv6:2601:641:700:5284:a912:b702:e7bd:4c27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 3B29524B3B; Fri, 8 Apr 2022 01:40:36 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.59.22031300 Date: Thu, 07 Apr 2022 18:40:33 -0700 Subject: Re: 885db9301ef9 - main - qlnx: Comment out remaining references to tx_data_bd. From: Ravi Pokala To: John Baldwin , , , Message-ID: <0FDDF3BC-0B91-405F-8E81-83309B1FA684@panasas.com> Thread-Topic: 885db9301ef9 - main - qlnx: Comment out remaining references to tx_data_bd. References: <202204080003.23803Vau086461@gitrepo.freebsd.org> In-Reply-To: <202204080003.23803Vau086461@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649382036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wsSWcR7P3jp1Sx8Td6c01YOB929UD10xkWfNDWBMPf0=; b=WWw5npscaJb7Rn1269JlazvsKOPpvLk9YIR53zzt8aEqmbDH4wmnC9KI3/7EiCTEski7+9 18iOd/PUs3ADplKGAa2DMxSUXtikKcCwit1acpaYfzdYaQcX9z7hkrKfQLUfKNemqBpulF el4QWvrN7ttAS97j9kSOpSJCQ6B/BcMeRxQdFpTHCl2X+jZGU7qe6KOp16wY5IphkNI1fx dNn69OPX+Icw4PZ0TnxJ//iWE+c0wbkg2iVe1XQpIgdbe6rEGZ/NTXlOcmh9oUDwSTNdIY K3lwFZbLBB469efdG83uilposLsRBJ6wU2kXi6BUACjCA+w7Uy9tBjWOcRYOFA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649382036; a=rsa-sha256; cv=none; b=lWTkZL+AGp7+v2+0hB1CsHzRHrnpQG+WFL4ECliff7vbjSoqtjg4LUpyxytTYVajpZ4tuU nNLY5xzmzUlUdkrh39XsXBF/o8Rz1yP+VRlciWobB9eSXIbyuLAbftLdwGYIlBc0wWoeHD q9YJBmJKjmJ/AekeS/nNPSZo1lAwO6+k2zHMx3LeCZleZG/vARZEwX7gk7UNQVekWtGzkb y8hivck6Eqp0epsbMYaxYGouYgo4G5mGz4m3+wh29usOeOX2CxmYjpCpABUY201L5QQQ17 nCIq2PZj+5ADw60tqo36UJB6C09H8LMAf0lVQ3AqqxJPpUKBe8t1iinbx7i9WQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N -----Original Message----- From: on behalf of John Baldwin Date: 2022-04-07, Thursday at 17:03 To: , , Subject: git: 885db9301ef9 - main - qlnx: Comment out remaining references to tx_data_bd. The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=885db9301ef9dfe420eff3c09aca497b7fc60924 commit 885db9301ef9dfe420eff3c09aca497b7fc60924 Author: John Baldwin AuthorDate: 2022-04-08 00:01:27 +0000 Commit: John Baldwin CommitDate: 2022-04-08 00:01:27 +0000 qlnx: Comment out remaining references to tx_data_bd. Why comment out, as opposed to removing outright (like most of the other unused-but-set cleanup)? Thanks, Ravi (rpokala@) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 4c1a55064a68..9e172e27ab35 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2909,7 +2909,7 @@ qlnx_free_tx_pkt(qlnx_host_t *ha, struct qlnx_fastpath *fp, struct mbuf *mp; bus_dmamap_t map; int i; - struct eth_tx_bd *tx_data_bd; +// struct eth_tx_bd *tx_data_bd; struct eth_tx_1st_bd *first_bd; int nbds = 0; @@ -2959,7 +2959,7 @@ qlnx_free_tx_pkt(qlnx_host_t *ha, struct qlnx_fastpath *fp, // BD_SET_UNMAP_ADDR_LEN(first_bd, 0, 0); for (i = 1; i < nbds; i++) { - tx_data_bd = ecore_chain_consume(&txq->tx_pbl); + /* tx_data_bd = */ ecore_chain_consume(&txq->tx_pbl); // BD_SET_UNMAP_ADDR_LEN(tx_data_bd, 0, 0); } txq->sw_tx_ring[idx].flags = 0;