From owner-freebsd-ports@freebsd.org  Fri Feb 10 05:53:12 2017
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18356CD7FC8
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Fri, 10 Feb 2017 05:53:12 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from anoxia.adamw.org (anoxia.adamw.org [104.225.8.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "anoxia.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id D036F1CF4
 for <freebsd-ports@freebsd.org>; Fri, 10 Feb 2017 05:53:11 +0000 (UTC)
 (envelope-from adamw@adamw.org)
Received: by anoxia.adamw.org (OpenSMTPD) with ESMTPSA id 43a7deca
 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO;
 Thu, 9 Feb 2017 22:53:10 -0700 (MST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\))
Subject: Re: Can't set maintainer-approval+ flag on an attachment
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <705473bd-9e65-ff1e-1a2d-9111854ff87d@bluerosetech.com>
Date: Thu, 9 Feb 2017 22:53:08 -0700
Cc: freebsd-ports@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <025A28A9-0B23-456A-A7BB-E78B76CAF7FE@adamw.org>
References: <705473bd-9e65-ff1e-1a2d-9111854ff87d@bluerosetech.com>
To: Mel Pilgrim <list_freebsd@bluerosetech.com>
X-Mailer: Apple Mail (2.3259)
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Feb 2017 05:53:12 -0000

> On 9 Feb, 2017, at 18:51, Mel Pilgrim <list_freebsd@bluerosetech.com> =
wrote:
>=20
> A PR for a port I maintain includes a patch. I'm supposed to set the =
maintainer-approval flag to + to approve the patch, but it doesn't seem =
to be working.  When I go to the patch details page, I can set =
maintainer-approval+, but it doesn't stick, even if I include a comment. =
 I found an older thread[1] from this list which mentions the patch has =
to be set to maintainer-approval? with my email address before I'm able =
to set maintainer-approval+.  The patch did not have =
maintainer-approval? set.  Is that bug still unfixed?
>=20
> 1: =
https://lists.freebsd.org/pipermail/freebsd-ports/2015-March/098255.html

Which PR?

# Adam


--=20
Adam Weinberger
adamw@adamw.org
https://www.adamw.org