From owner-cvs-src@FreeBSD.ORG  Sat Jan 12 21:19:23 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 03C2016A417;
	Sat, 12 Jan 2008 21:19:23 +0000 (UTC) (envelope-from das@FreeBSD.ORG)
Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179])
	by mx1.freebsd.org (Postfix) with ESMTP id 97CE913C467;
	Sat, 12 Jan 2008 21:19:22 +0000 (UTC) (envelope-from das@FreeBSD.ORG)
Received: from VARK.MIT.EDU (localhost [127.0.0.1])
	by VARK.MIT.EDU (8.14.2/8.14.1) with ESMTP id m0CLJJIh003485;
	Sat, 12 Jan 2008 16:19:19 -0500 (EST) (envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by VARK.MIT.EDU (8.14.2/8.14.1/Submit) id m0CLJJL2003484;
	Sat, 12 Jan 2008 16:19:19 -0500 (EST) (envelope-from das@FreeBSD.ORG)
Date: Sat, 12 Jan 2008 16:19:19 -0500
From: David Schultz <das@FreeBSD.ORG>
To: Maxim Konovalov <maxim@macomnet.ru>
Message-ID: <20080112211919.GA3408@VARK.MIT.EDU>
Mail-Followup-To: Maxim Konovalov <maxim@macomnet.ru>,
	src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG,
	cvs-all@FreeBSD.ORG
References: <200801122037.m0CKb6CS009262@repoman.freebsd.org>
	<20080112205254.GB3090@VARK.MIT.EDU>
	<20080112235350.C10888@mp2.macomnet.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080112235350.C10888@mp2.macomnet.net>
Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/usr.sbin/iostat iostat.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Jan 2008 21:19:23 -0000

On Sat, Jan 12, 2008, Maxim Konovalov wrote:
> On Sat, 12 Jan 2008, 15:52-0500, David Schultz wrote:
> 
> > On Sat, Jan 12, 2008, Maxim Konovalov wrote:
> > > -			asprintf(&devname, "%s%d",
> > > +			if (asprintf(&devname, "%s%d",
> > >  			    cur.dinfo->devices[di].device_name,
> > > -			    cur.dinfo->devices[di].unit_number);
> > > +			    cur.dinfo->devices[di].unit_number) == 1)
> > > +				errx(1, "asprintf() failed (out of memory?)");
> >
> > err(1, "asprintf") will produce a more meaningful error message,
> > by the way. Also, I think you wanted to compare the return value
> > of asprintf to -1 instead of 1.
> >
> err(1, "asprintf") was my first version, yes.  But I failed to find in
> the man page it sets errno.  Thanks for the review, I'll fix the typo
> shortly.

I don't think it always does set errno, but you can set errno to 0
before the call, and you'll get either the real error message from
err() or "unknown error".