From owner-svn-src-all@FreeBSD.ORG Mon May 17 21:55:47 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CAC94106567A; Mon, 17 May 2010 21:55:47 +0000 (UTC) (envelope-from neelnatu@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id 7F3718FC16; Mon, 17 May 2010 21:55:47 +0000 (UTC) Received: by pvh11 with SMTP id 11so2705650pvh.13 for ; Mon, 17 May 2010 14:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=nFIvdCPzEo1Fa18exaakf5ndtkLDY+MAknQmaN02ROU=; b=LSiUvb2WmCOfkGtA/PhpASGhV+ds8RJHoZQDWQjnF24hek32ZP4489dyHAnLDMc14N /MQtbLN2ZiKoHcySWJia38xQGFU3oQJhCD5vdLG8MV/cKoqDCC9wWsyPPpPdNi49TE2d 4uM61oLedlCya8N1qNklgNZs6S3iOy4A9UoiA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=N9VByb0oRTomcH31Bp6R/dLxXoMmAt1Yrq6p+8BYK2YUwV4i5FLYZV6Eopjo0KWxcF aCmtjzRCz6MtfS05ubchAm3UKFyi2yDYwCc+cCHORZcUFe0uOaEQuUrDrdaOEiCfc6UR 4SWaXQfbz/+1yC3in5XTiBnvEDKqgI/cr75Ow= MIME-Version: 1.0 Received: by 10.143.25.2 with SMTP id c2mr3981095wfj.147.1274133346363; Mon, 17 May 2010 14:55:46 -0700 (PDT) Received: by 10.142.172.9 with HTTP; Mon, 17 May 2010 14:55:46 -0700 (PDT) In-Reply-To: References: <201005161943.o4GJhnTo096839@svn.freebsd.org> Date: Mon, 17 May 2010 14:55:46 -0700 Message-ID: From: Neel Natu To: Juli Mallett Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, Randall Stewart , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r208165 - in head/sys: kern mips/conf mips/include mips/mips mips/rmi mips/rmi/dev/xlr X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2010 21:55:47 -0000 Hi Randall, On Sun, May 16, 2010 at 12:54 PM, Juli Mallett wrote= : > On Sun, May 16, 2010 at 12:43, Randall Stewart wrote: >> Author: rrs >> Date: Sun May 16 19:43:48 2010 >> New Revision: 208165 >> URL: http://svn.freebsd.org/changeset/base/208165 >> >> Log: >> =A0This pushes all of JC's patches that I have in place. I >> =A0am now able to run 32 cores ok.. but I still will hang >> =A0on buildworld with a NFS problem. I suspect I am missing >> =A0a patch for the netlogic rge driver. >> >> =A0JC check and see if I am missing anything except your >> =A0core-mask changes > > This isn't a very good commit message. =A0Commits communicate things > going forward. =A0A follow-up E-Mail CCing JC would have been a good way > to chat with him about its completeness. =A0More importantly, though, > there's just no description of the contents. =A0This is particularly > frustrating as it's also not broken up into functional chunks very > well. =A0Given the fact that there are MI changes and pan-MIPS changes > here it would be nice to see a little more care taken. =A0The changes to > the MIPS MP code, for instance, I thought we had discussed and decided > were sub-par and easily made less invasive. =A0I can't comment on the > RMI-specific stuff except to say that it's an unenumerated jumble of > VM, networking and SMP changes. > I agree with Juli. This is especially true with respect to the changes to pmap.c. There needed to be a companion set of changes to exception.S to undo some of the changes to the TLB invalid handler that deal with recursive faults in the TLB miss handler. best Neel