From owner-freebsd-ports@freebsd.org Wed Nov 6 08:56:23 2019 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ABA4D1AEDB5 for ; Wed, 6 Nov 2019 08:56:23 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 477L4747Cmz3K6F; Wed, 6 Nov 2019 08:56:23 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from ivaldir.etoilebsd.net (etoilebsd.net [178.32.217.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 5A2458125; Wed, 6 Nov 2019 08:56:23 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by ivaldir.etoilebsd.net (Postfix, from userid 1001) id DFC29BFDB3; Wed, 6 Nov 2019 09:56:21 +0100 (CET) Date: Wed, 6 Nov 2019 09:56:21 +0100 From: Baptiste Daroussin To: Russell Haley Cc: freebsd-ports@freebsd.org Subject: Re: Adding FLAVORS to lua-luarocks Message-ID: <20191106085621.6ghgryrttdgb442z@ivaldir.net> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="omrkt4mvgtzsx372" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Nov 2019 08:56:23 -0000 --omrkt4mvgtzsx372 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 05, 2019 at 09:43:48PM -0800, Russell Haley wrote: > Hello, >=20 > I have a review for updating the Lua package manager - LuaRocks - it to t= he > latest revision, 3.2.1. The new port file uses an update to lua.mk from > Andrew Gierth for using FLAVORS to support all available versions of Lua. > The reviews are here: (LuaRocks) https://reviews.freebsd.org/D17814 and > here: (Lua.mk) https://reviews.freebsd.org/D16494 >=20 > In the LuaRocks port, I've added the flavors as a selection of port OPTIO= NS > to build the correct version. Unfortunately, using the OPTIONS isn't ideal > because it will save the selected option for the next time the port is ru= n, > but that's not the desired use case. I wanted the build to *always* prompt > for a Lua version so it can be used for multiple side by side Lua > installations. >=20 > Any suggestions, alternatives to OPTIONS or other constructive input would > be appreciated. >=20 If the lua.mk ever get the support for flavors committed in, there is no ne= ed to add any option framework or whatever to allow the user to pickup a flavor. if someone $ants to only build for a given flavor he will have to just to r= un: make FLAVOR=3Dlua52 if building from poudriere: poudriere bulk devel/lua-rocks@lua52 Best regards, Bapt --omrkt4mvgtzsx372 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl3CipcACgkQY4mL3PG3 PlrRYxAAnPoydn/3GQt67bdKUKhItyEdCvGF0vuci0OhG7sbFbnA8my3oRa702LX lSFENQESQYFLRphNPxaCGGCaItigUMXpUlmI57uvYILxqxLl7WUrS2VNH/RNdEn8 TTU4RCqhERRatwihZ8S7/hxtfRyGHpilD77ujoxtgIkL85Gl6va6O9lYcrdRaoHM qUBU8YJlbzUoLRM5fjUoIbT+iUoakiwFkk6EU9smDRIo3YQsXAT6D9YfMWZD0/2u 7PIMT8g+TUwp6sdMwm+WXk1FnltFRsMkf4LSxLoiqRky2pkqeFYCGM9h3k18iClI 8UiYc0hhzTVrygYQb4wEqlTG6N8bd14ljH3WGiQ7yLg9YBHqiS41QdXN8l86uNEK x4GBX23HmKiXelaSHqQnKbAcSkqgOH3WEKQAZhb6MrplsBXTJohF60muPU3suNsQ Z62YvtIGjGLulKMrtR5mH26vUBCza0z/9W9e7NQwjOJxQLaLFvC+YNitHIj1TGfW PxucbiILaGaAFEFXxusE8p0Nho7ZV+0QriKJIqYWx+CE5tFpKF1AHMditkDFZXUf pf+xJmwsh83/NFUYmODFR0/ioy/oJmq0Oz7Y0P7cBXzIKzy51pYYkHuuBJEKiFuq VGY9pgU3gZ7I5nEySwG+DvKrjxN06p9d9YnqOkytzvhghiuknhU= =Po3y -----END PGP SIGNATURE----- --omrkt4mvgtzsx372--