From owner-cvs-src@FreeBSD.ORG Thu Mar 30 19:47:08 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA56C16A401; Thu, 30 Mar 2006 19:47:08 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.171]) by mx1.FreeBSD.org (Postfix) with ESMTP id 63B4443D76; Thu, 30 Mar 2006 19:47:01 +0000 (GMT) (envelope-from max@love2party.net) Received: from [88.64.177.54] (helo=amd64.laiers.local) by mrelayeu.kundenserver.de (node=mrelayeu8) with ESMTP (Nemesis), id 0ML2ov-1FP36h1gES-0004ZY; Thu, 30 Mar 2006 21:46:59 +0200 From: Max Laier Organization: FreeBSD To: "Bjoern A. Zeeb" Date: Thu, 30 Mar 2006 21:45:50 +0200 User-Agent: KMail/1.9.1 References: <200603301857.k2UIv46o066136@repoman.freebsd.org> <20060330191338.Q2181@maildrop.int.zabbadoz.net> In-Reply-To: <20060330191338.Q2181@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2478221.rrnyWhTfxf"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200603302145.57382.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de login:61c499deaeeba3ba5be80f48ecc83056 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netipsec xform.h xform_ipip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2006 19:47:09 -0000 --nextPart2478221.rrnyWhTfxf Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 30 March 2006 21:17, Bjoern A. Zeeb wrote: > On Thu, 30 Mar 2006, Bjoern A. Zeeb wrote: > > bz 2006-03-30 18:57:04 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/netipsec xform.h xform_ipip.c > > Log: > > Fix more stack corruptions on amd64. > > > > Vararg functions have a different calling convention than regular > > functions on amd64. Casting a varag function to a regular one to > > match the function pointer declaration will hide the varargs from > > the caller and we will end up with an incorrectly setup stack. > > I will try to go over sys/net*/** or even sys/** somewhen the next > days and see if I can find more of them. > > If anybody knows an easy way to find all casted function pointers > that are using varargs let me know ;-) Shouldn't we be able to teach Coverity? It certainly has the information=20 somewhere. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart2478221.rrnyWhTfxf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (FreeBSD) iD8DBQBELDV1XyyEoT62BG0RAok+AJ4zMxAu9W4lkyonkcHlzgJTu2godgCfV/K5 HbjHQjp28Do3wHzlca41sZk= =IvRD -----END PGP SIGNATURE----- --nextPart2478221.rrnyWhTfxf--