Date: Thu, 30 Mar 2006 21:45:50 +0200 From: Max Laier <max@love2party.net> To: "Bjoern A. Zeeb" <bz@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netipsec xform.h xform_ipip.c Message-ID: <200603302145.57382.max@love2party.net> In-Reply-To: <20060330191338.Q2181@maildrop.int.zabbadoz.net> References: <200603301857.k2UIv46o066136@repoman.freebsd.org> <20060330191338.Q2181@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart2478221.rrnyWhTfxf Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 30 March 2006 21:17, Bjoern A. Zeeb wrote: > On Thu, 30 Mar 2006, Bjoern A. Zeeb wrote: > > bz 2006-03-30 18:57:04 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/netipsec xform.h xform_ipip.c > > Log: > > Fix more stack corruptions on amd64. > > > > Vararg functions have a different calling convention than regular > > functions on amd64. Casting a varag function to a regular one to > > match the function pointer declaration will hide the varargs from > > the caller and we will end up with an incorrectly setup stack. > > I will try to go over sys/net*/** or even sys/** somewhen the next > days and see if I can find more of them. > > If anybody knows an easy way to find all casted function pointers > that are using varargs let me know ;-) Shouldn't we be able to teach Coverity? It certainly has the information=20 somewhere. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart2478221.rrnyWhTfxf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (FreeBSD) iD8DBQBELDV1XyyEoT62BG0RAok+AJ4zMxAu9W4lkyonkcHlzgJTu2godgCfV/K5 HbjHQjp28Do3wHzlca41sZk= =IvRD -----END PGP SIGNATURE----- --nextPart2478221.rrnyWhTfxf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603302145.57382.max>