From owner-freebsd-bugs@FreeBSD.ORG Wed Aug 24 22:00:38 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D886416A41F for ; Wed, 24 Aug 2005 22:00:38 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F8AE43D48 for ; Wed, 24 Aug 2005 22:00:38 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j7OM0c93077741 for ; Wed, 24 Aug 2005 22:00:38 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j7OM0c8t077734; Wed, 24 Aug 2005 22:00:38 GMT (envelope-from gnats) Resent-Date: Wed, 24 Aug 2005 22:00:38 GMT Resent-Message-Id: <200508242200.j7OM0c8t077734@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Simon Morgan Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 23DF316A41F for ; Wed, 24 Aug 2005 21:55:04 +0000 (GMT) (envelope-from simon@bollo.16hz.net) Received: from bollo.16hz.net (bollo.16hz.net [82.71.120.78]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8245D43D53 for ; Wed, 24 Aug 2005 21:55:03 +0000 (GMT) (envelope-from simon@bollo.16hz.net) Received: from bollo.16hz.net (localhost.16hz.net [127.0.0.1]) by bollo.16hz.net (8.13.3/8.13.3) with ESMTP id j7P3qAbo085195; Thu, 25 Aug 2005 04:52:10 +0100 (BST) (envelope-from simon@bollo.16hz.net) Received: (from simon@localhost) by bollo.16hz.net (8.13.3/8.13.3/Submit) id j7P3q84s085194; Thu, 25 Aug 2005 04:52:08 +0100 (BST) (envelope-from simon) Message-Id: <200508250352.j7P3q84s085194@bollo.16hz.net> Date: Thu, 25 Aug 2005 04:52:08 +0100 (BST) From: Simon Morgan To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: sjmorgan@gmail.com Subject: kern/85271: [patch] log() call in if_atm.c omits newline X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2005 22:00:39 -0000 >Number: 85271 >Category: kern >Synopsis: [patch] log() call in if_atm.c omits newline >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Aug 24 22:00:37 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Simon Morgan >Release: FreeBSD 5.4-RELEASE i386 >Organization: None >Environment: System: FreeBSD bollo.16hz.net 5.4-RELEASE FreeBSD 5.4-RELEASE #0: Wed Aug 24 16:58:18 BST 2005 root@bollo.16hz.net:/usr/obj/usr/src/sys/BOLLO i386 >Description: Current behaviour results in the following output on my system: atmresolve: BCAST/MCAST packet detected/dumpedatmresolve: BCAST/MCAST packet detected/dumpedatmresolve: BCAST/MCAST packet detected/dumpedatmresolve: BCAST/MCAST packet detected/dumpedatmresolve: BCAST/MCAST packet detected/dumpedueagle0: opening ATM virtual circuit >How-To-Repeat: N/A >Fix: --- /usr/src/sys/netinet/if_atm.c.orig Mon Jan 31 23:26:35 2005 +++ /usr/src/sys/netinet/if_atm.c Thu Aug 25 04:35:23 2005 @@ -312,7 +312,7 @@ struct sockaddr_dl *sdl; if (m->m_flags & (M_BCAST | M_MCAST)) { - log(LOG_INFO, "atmresolve: BCAST/MCAST packet detected/dumped"); + log(LOG_INFO, "atmresolve: BCAST/MCAST packet detected/dumped\n"); goto bad; } >Release-Note: >Audit-Trail: >Unformatted: