From owner-freebsd-x11@FreeBSD.ORG Thu Feb 13 23:38:36 2014 Return-Path: Delivered-To: freebsd-x11@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8EE5EDBC for ; Thu, 13 Feb 2014 23:38:36 +0000 (UTC) Received: from mail-qc0-x230.google.com (mail-qc0-x230.google.com [IPv6:2607:f8b0:400d:c01::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 46E3311E0 for ; Thu, 13 Feb 2014 23:38:36 +0000 (UTC) Received: by mail-qc0-f176.google.com with SMTP id e16so18857445qcx.7 for ; Thu, 13 Feb 2014 15:38:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=1O5hLQZBWYVbIIPJGl5NxqEGAjCTLPGiKDOyYwP1hSY=; b=nD2RDscgxR2xDaRzsDKH/+Z4qXXYoa8vwTT0wZcbaT2nlbiq3gon8rfevX7VIIzYfo Hg4x5/8ZvfQDGW6EJ7X+9eX7t/iI/WTJsQ16DNFOOW66ge0UwkpoAqhta+VeUruYVhgV k1FymfLEI97OZU2JaLsH+YYi6t2SGn+ECNMSw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=1O5hLQZBWYVbIIPJGl5NxqEGAjCTLPGiKDOyYwP1hSY=; b=NeYPG17PC+CssdEiALrLkQU13VVfkgXlU86BCvJ0itF7DMhK1fCK+LF0kN6YSFeS8v mC0yKfPXGoT+WPRHA8eNVeMhG1qQDUKOhZ3lgPxdwPvpo/CUUgtEOESjwsaBtkEe3Bkd /cpTHQ1acQqhgaBf6xQAE4z6QqBiwZGNt1O9Mk7a8U2A5x+odDykvkVBSTBrNXlKWGG3 SzTU6Dgr4QekJdW1pnOnXKWUTrOcz/jvirORqHrHNLUUK3WXRZIvkYLYRKczmTO6jrwY D3WFgJSP7E3dWREwDpr/k9BnB7Z0wG4rT0Hy0IFV1TkNDNSqHVJlz+VgOElcBBQnvoID AR1Q== X-Gm-Message-State: ALoCoQlw7kD4fIdoRRJRhjF9vNR8g2PVQREI0eT106yjW6R3gIDdZEZrcSZ3ka9kU8eKhvwf/F6P X-Received: by 10.140.87.172 with SMTP id r41mr6937279qgd.101.1392334715435; Thu, 13 Feb 2014 15:38:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.96.175.169 with HTTP; Thu, 13 Feb 2014 15:38:05 -0800 (PST) In-Reply-To: <52FD5625.6010604@freebsd.org> References: <52EFAC5D.8010603@freebsd.org> <52FD5625.6010604@freebsd.org> From: Eitan Adler Date: Thu, 13 Feb 2014 18:38:05 -0500 Message-ID: Subject: Re: [PATCH] ignore uhid devices in X devd backend To: Robert Millan Content-Type: text/plain; charset=UTF-8 Cc: freebsd-x11@freebsd.org, Alex Kozlov X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Feb 2014 23:38:36 -0000 On Thu, Feb 13, 2014 at 6:32 PM, Robert Millan wrote: > On 03/02/2014 14:49, Robert Millan wrote: >> >> This patch removes uhid from the hw_types[] list. According to the >> uhid driver description, this driver is only a fallback for devices >> not supported by any other driver. >> >> On my system, the USB keyboard shows up as an uhid device in addition >> to /dev/ukbd0, but the previous devd code misidentified it as a mouse. >> >> This just leads to trouble when X attempts to open() it and fails, >> for the reasons described in my earlier devd_no_kbd.diff patch. > > This might no longer apply with the code in: > > http://trillian.chruetertee.ch/ports/browser/trunk/x11-servers/xorg-server/files/extra-devd > > which includes an open() test with fallback. > > (still I don't see the point of processing uhid devices, though) Even so, we still don't want to bother processing devices which can't possibly be correct. -- Eitan Adler