From owner-freebsd-current@FreeBSD.ORG Thu Feb 22 21:55:30 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 183B716A403 for ; Thu, 22 Feb 2007 21:55:30 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id B07D013C442 for ; Thu, 22 Feb 2007 21:55:29 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l1MLsG9f016131; Thu, 22 Feb 2007 14:54:17 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Thu, 22 Feb 2007 14:54:16 -0700 (MST) Message-Id: <20070222.145416.1649769748.imp@bsdimp.com> To: gurney_j@resnet.uoregon.edu From: "M. Warner Losh" In-Reply-To: <20070219224006.GC73385@funkthat.com> References: <20070219020725.A56400@xorpc.icir.org> <20070219224006.GC73385@funkthat.com> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Thu, 22 Feb 2007 14:54:18 -0700 (MST) Cc: rizzo@icir.org, current@freebsd.org Subject: Re: can a valid bus_dma_tag_t be NULL ? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2007 21:55:30 -0000 In message: <20070219224006.GC73385@funkthat.com> John-Mark Gurney writes: : > if (bus_dma_tag_create(NULL, 4, 0, BUS_SPACE_MAXADDR_32BIT, : ^^^^ : This is incorrect, and should be: bus_get_dma_tag(dev), though that is : correct for -stable, (or have we introduced bus_get_dma_tag into -stable?) There's currently a compat shim: #define bus_get_dma_tag(dev) NULL so you shuold use it for both -current and -stable. Warner