From owner-svn-src-all@freebsd.org Tue Sep 13 01:21:27 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 602A5BD775A; Tue, 13 Sep 2016 01:21:27 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-vk0-x22a.google.com (mail-vk0-x22a.google.com [IPv6:2607:f8b0:400c:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 172DDCEC; Tue, 13 Sep 2016 01:21:27 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-vk0-x22a.google.com with SMTP id v189so159560511vkv.1; Mon, 12 Sep 2016 18:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=XCr+jeLrl2VPUuXQDl8zmSQfc6tN19XsuVBlZ+lUkJY=; b=RbYbKBXMWcjOsa1FV2Qc7+MRlCQGyz65jicJlKlEVsF2OQCijyTLLfaR6T+XkWnXAb vX1QSDZwJEyenrt2VhimbQP+PYJokmMmgkS+7T0YxawVdduSGUZrhejI8pwAWsq4ouNJ lXQALdCWPjWyokXU6WNlJUtSx6X4KJ6Lu2KgY6clb7tRbTYkUhpSHNCa5aTSjiWsLNF+ len4NoczEt6cS7D28Bzmr6wLRSyi5zRHi7FtYnSwi3n60XdCAaSLQPlBtpV9AsSo7n6D UBPIaUGKzXmpN6EO2NWihWMsrgGJsfGb12ajgah6VTaoroDMlGKC9EB9dy6UXBSJ3iPA ZysQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=XCr+jeLrl2VPUuXQDl8zmSQfc6tN19XsuVBlZ+lUkJY=; b=GFuTppgL/vakZNi40Ps2Hke5pcLvSXaGcwITwbOz9VeUAPQMXGW/K2cHCY4BDaICC0 Cc2QZjpq0pOflQWMzaKY/vDeUDjkgeAn43H81bcV3AdyY0dqa5OzVsWKJA+OQatqzGjf JmhD0vFF3HjzIanP5jddXHLGiGN0Y4G28XMABKwRZvshTIHC/c1Gu1thJFoXNCM7e2Tk UdKNOr+lWDI86dAcL8bv+UTHKYtsJ6PPqxKnRwz8fAc2jsfv5OuPy48s78ELn13pLEMy AIVSmwhdJTEc1+K/oLN8vARE1CDettww+jNdTP2h5HkgNiAVGcEC6ShgII8OVxSQxu3I tf1A== X-Gm-Message-State: AE9vXwOgjDf5Nrs7a25IZDN0bPHtLlthsVMfSozzRLvcfc2htsEbqpd042mxB2eM77kgkFQAlyM6ekVofeAYxg== X-Received: by 10.31.65.210 with SMTP id o201mr12195322vka.0.1473729686220; Mon, 12 Sep 2016 18:21:26 -0700 (PDT) MIME-Version: 1.0 Sender: sepherosa@gmail.com Received: by 10.176.69.228 with HTTP; Mon, 12 Sep 2016 18:21:25 -0700 (PDT) In-Reply-To: <20160912100003.GX38409@kib.kiev.ua> References: <201609120457.u8C4vw9S052665@repo.freebsd.org> <20160912083228.GW38409@kib.kiev.ua> <20160912100003.GX38409@kib.kiev.ua> From: Sepherosa Ziehau Date: Tue, 13 Sep 2016 09:21:25 +0800 X-Google-Sender-Auth: SW23PSrQB-LdPTsukKQnraRj6qs Message-ID: Subject: Re: svn commit: r305722 - head/sys/x86/x86 To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2016 01:21:27 -0000 On Mon, Sep 12, 2016 at 6:00 PM, Konstantin Belousov wrote: > On Mon, Sep 12, 2016 at 04:47:35PM +0800, Sepherosa Ziehau wrote: >> On Mon, Sep 12, 2016 at 4:39 PM, Sepherosa Ziehau wrote: >> > On Mon, Sep 12, 2016 at 4:32 PM, Konstantin Belousov >> > wrote: >> >> On Mon, Sep 12, 2016 at 04:57:58AM +0000, Sepherosa Ziehau wrote: >> >>> Author: sephe >> >>> Date: Mon Sep 12 04:57:58 2016 >> >>> New Revision: 305722 >> >>> URL: https://svnweb.freebsd.org/changeset/base/305722 >> >>> >> >>> Log: >> >>> x86: Use sx lock for interrupt sources. >> >>> >> >>> - Certain pic_assign_cpu, e.g. msi_assign_cpu can have quite a long >> >>> call chain. For msi_assign_cpu, mutex makes complex PCI bridge >> >>> drivers more tricky, e.g. sleep can note be called, etc, it will >> >>> be pretty tricky for upcoming Hyper-V PCI bridge driver for PCI >> >>> pass-through. >> >> >> >>> - It is not used on any hot code path nor non-sleepable context, so >> >>> sx should have the same effect as mutex. >> >> Did you tested ACPI_DMAR interrupt remapping mode with your patch and >> >> witness enabled ? >> > >> > Nope, I am about to try it now. BTW, I just checked the code for >> > ACPI_DMAR, I didn't see anything obviously w/ the lock type change >> > though. >> >> I didn't notice anything wrong w/ options >> ACPI_DMAR+WITNESS+INVARIANTS. If you saw anything wrong, please let >> me know. > > Options are not enough, you should explicitely enable interrupt remapping > with loader tunable hw.dmar.ir=1. Still didn't find anything wrong with this tunable set. Thanks, sephe -- Tomorrow Will Never Die