From nobody Wed Dec 3 14:05:54 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dLzv90P7zz6JRjh; Wed, 03 Dec 2025 14:05:57 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta004.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dLzv85GkQz4Mwn; Wed, 03 Dec 2025 14:05:56 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004b.ext.cloudfilter.net ([10.228.9.230]) by cmsmtp with ESMTPS id QjdxvQ7sxPzKyQnUSvfadM; Wed, 03 Dec 2025 14:05:56 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id QnUQvI3l35aoCQnURven3v; Wed, 03 Dec 2025 14:05:55 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=YMSSCBGx c=1 sm=1 tr=0 ts=693043c3 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=wP3pNCr1ah4A:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=Q-fNiiVtAAAA:8 a=YxBL1-UpAAAA:8 a=F3s4GREXQDzkHWVKJioA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy.cwsent.com [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 1D9C2509; Wed, 03 Dec 2025 06:05:54 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 150B71E8; Wed, 03 Dec 2025 06:05:54 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Sumit Saxena cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 35dd53a9e132 - main - librdmacm/libibverbs: Statically bound libbnxtre.so.1 to rping In-reply-to: <69302037.3d155.40084cd7@gitrepo.freebsd.org> References: <69302037.3d155.40084cd7@gitrepo.freebsd.org> Comments: In-reply-to Sumit Saxena message dated "Wed, 03 Dec 2025 11:34:15 +0000." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 03 Dec 2025 06:05:54 -0800 Message-Id: <20251203140554.150B71E8@slippy.cwsent.com> X-CMAE-Envelope: MS4xfNuUThzO7MZ4jxFnJZpRQPIKETlA+HjFWZWsvIdU1OncXsQZviEyxmZaQqS7UuLfgreuVeK1uUPqphJQjNfmCik0/9UkEvr1mwRTQwMNxZitNyVPqjj7 EtsyXygDWppXdmRff9TdRoCPCjOs/R2POY2Lcay2/Me3OZVBGjCeh3fAbiDXy5aWXu8aDZn9+SLWu/Bhz8YcNWv9jTR8fy4KW+Xb7/GzYe7ebbpoFcYVf1Sa TW580eR4dcKWagWnT26RogO+CRcDdTkjtq0AkUjVdAuae0+y4VqMORsh/qJvvg5Z02EHlvJTPM6htU9IP+gLs8Q3ulYUOP7lGKFcP1U7ijk= X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dLzv85GkQz4Mwn In message <69302037.3d155.40084cd7@gitrepo.freebsd.org>, Sumit Saxena writes: > The branch main has been updated by ssaxena: > > URL: https://cgit.FreeBSD.org/src/commit/?id=35dd53a9e13265f7a479649776453efc > 5b737a0f > > commit 35dd53a9e13265f7a479649776453efc5b737a0f > Author: Sumit Saxena > AuthorDate: 2025-12-03 11:28:33 +0000 > Commit: Sumit Saxena > CommitDate: 2025-12-03 11:33:40 +0000 > > librdmacm/libibverbs: Statically bound libbnxtre.so.1 to rping > > By default ibv_devices and rping are not statically bound to > libbnxtre.so.1. i.e. 'ldd /usr/bin/rping' command doesn't list > 'libbnxtre.so.1' entry. So, statically bound the libbnxtre.so.1 > library to rping & ibv_devices utils. > > MFC-After: 3 days > Reviewed-by: sumit.saxena@broadcom.com It's odd to review your own work. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0 > Differential-Revision: https://reviews.freebsd.org/D49604 > --- > share/mk/src.libnames.mk | 7 +++++-- > usr.bin/ofed/libibverbs/Makefile.inc | 2 +- > usr.bin/ofed/librdmacm/Makefile.inc | 2 +- > 3 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/share/mk/src.libnames.mk b/share/mk/src.libnames.mk > index e108cc15fb55..125fe2242bd5 100644 > --- a/share/mk/src.libnames.mk > +++ b/share/mk/src.libnames.mk > @@ -285,6 +285,7 @@ _LIBRARIES+= \ > irdma \ > mlx4 \ > mlx5 \ > + bnxtre \ > rdmacm \ > osmcomp \ > opensm \ > @@ -360,7 +361,7 @@ _DP_cap_sysctl= nv > _DP_cap_syslog= nv > _DP_crypt= md > .if ${MK_OFED} != "no" > -_DP_pcap= ibverbs mlx5 > +_DP_pcap= ibverbs mlx5 bnxtre > .endif > _DP_pjdlog= util > _DP_usb= pthread > @@ -511,11 +512,12 @@ _DP_cxgb4= ibverbs pthread > _DP_ibcm= ibverbs > _DP_ibmad= ibumad > _DP_ibnetdisc= osmcomp ibmad ibumad > -_DP_ibumad= > +_DP_ibumad= > _DP_ibverbs= > _DP_irdma= ibverbs pthread > _DP_mlx4= ibverbs pthread > _DP_mlx5= ibverbs pthread > +_DP_bnxtre= ibverbs pthread > _DP_rdmacm= ibverbs > _DP_osmcomp= pthread > _DP_opensm= pthread > @@ -810,6 +812,7 @@ LIBIBVERBSDIR= ${_LIB_OBJTOP}/lib/ofed/libibverbs > LIBIRDMADIR= ${_LIB_OBJTOP}/lib/ofed/libirdma > LIBMLX4DIR= ${_LIB_OBJTOP}/lib/ofed/libmlx4 > LIBMLX5DIR= ${_LIB_OBJTOP}/lib/ofed/libmlx5 > +LIBBNXTREDIR= ${_LIB_OBJTOP}/lib/ofed/libbnxtre > LIBRDMACMDIR= ${_LIB_OBJTOP}/lib/ofed/librdmacm > LIBOSMCOMPDIR= ${_LIB_OBJTOP}/lib/ofed/complib > LIBOPENSMDIR= ${_LIB_OBJTOP}/lib/ofed/libopensm > diff --git a/usr.bin/ofed/libibverbs/Makefile.inc b/usr.bin/ofed/libibverbs/M > akefile.inc > index 616c9bd54707..f8301c3d1073 100644 > --- a/usr.bin/ofed/libibverbs/Makefile.inc > +++ b/usr.bin/ofed/libibverbs/Makefile.inc > @@ -3,6 +3,6 @@ _spath=${SRCTOP}/contrib/ofed/libibverbs > > BINDIR?= /usr/bin > CFLAGS+= -I${_spath} > -LIBADD+= ibverbs mlx4 mlx5 cxgb4 irdma pthread > +LIBADD+= ibverbs mlx4 mlx5 bnxtre cxgb4 irdma pthread > > WARNS?= 2 > diff --git a/usr.bin/ofed/librdmacm/Makefile.inc b/usr.bin/ofed/librdmacm/Mak > efile.inc > index 74f32fe08b42..66fcf2ac267b 100644 > --- a/usr.bin/ofed/librdmacm/Makefile.inc > +++ b/usr.bin/ofed/librdmacm/Makefile.inc > @@ -3,6 +3,6 @@ _spath=${SRCTOP}/contrib/ofed/librdmacm > > BINDIR?= /usr/bin > CFLAGS+= -I${SRCTOP}/contrib/ofed > -LIBADD+= ibverbs rdmacm irdma mlx4 mlx5 cxgb4 pthread > +LIBADD+= ibverbs rdmacm irdma mlx4 mlx5 bnxtre cxgb4 pthread > > WARNS?= 0 >