From owner-freebsd-current@FreeBSD.ORG Thu Oct 18 00:00:33 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0BFA9D8 for ; Thu, 18 Oct 2012 00:00:33 +0000 (UTC) (envelope-from jim.harris@gmail.com) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id A73598FC0C for ; Thu, 18 Oct 2012 00:00:32 +0000 (UTC) Received: by mail-vb0-f54.google.com with SMTP id v11so10212996vbm.13 for ; Wed, 17 Oct 2012 17:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=H2lIHrpa8h9F1HrTEdfzgqJRHxKFQMN3WQ/zHQEdMkY=; b=mga/jJXND7ZgoIhfba9G1f9BV5cvS3KrpSp90lF7qY8vk6gTfdvhzNpdXXEX625qD+ Nj3Oh5ozqtTSYa6QmOxccPRKp1JEyGj4A2Ik1SByYIgbb8OCLpQoSQ3uZkClCtoMZXOu aqbu++FzJjM0n6JOidYW/nZMDUOWXHgy8FKEFBYbvcs/gjVCq3jZ062SCSJ/8bBhdgJL Yypbe3iDwWJVfvlVEzcE/hDLBsK2CTDT2UizGmCQ0/s9vEaOmd8OtNpVqdMGjv12UZet H3iYvI/RssTisEYRbPDIwmbq506rChU9Jw5+6vk8Elg1njUshidrJIyHvCf9B4M5Ts30 cCPQ== MIME-Version: 1.0 Received: by 10.52.35.82 with SMTP id f18mr9747966vdj.99.1350518431443; Wed, 17 Oct 2012 17:00:31 -0700 (PDT) Received: by 10.58.225.2 with HTTP; Wed, 17 Oct 2012 17:00:31 -0700 (PDT) In-Reply-To: References: <1349390777.5234.9.camel@powernoodle.corp.yahoo.com> Date: Wed, 17 Oct 2012 17:00:31 -0700 Message-ID: Subject: Re: [CFT]hwpmc update for sandybridge-e From: Jim Harris To: hiren panchasara Content-Type: text/plain; charset=ISO-8859-1 Cc: Davide Italiano , freebsd-current , Fabien Thomas X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2012 00:00:33 -0000 On Wed, Oct 17, 2012 at 3:57 PM, hiren panchasara wrote: > > > > Thanks for the pointers Jim! > > It seems that everything works now with: > > http://www.strugglingcoder.info/patches/hwpmc_sbx_3.txt > http://www.strugglingcoder.info/patches/pmccontrol_3.txt > http://www.strugglingcoder.info/patches/pmctestpy_3.txt > > As it can be seen, I do not see any errors with the test script. > I've also tried to take care of the sorting issues Fabien mentioned. > > Can you please give this a whirl? Looks good! Version 3 passes pmctest.py on my system. > > > I have a few questions regarding this. For my testing I am using hwpmc as a > module. > Problem is that any change to pmc_events.h is not reflected when I do: > 1) rebuild /sys/modules/hwpmc - unload/load new module > 2) rebuild /lib/libpmc/ > 3) rebuild /usr.sbin/pmccontrol and pmcstat > > I have to do buildworld for changes in pmc_events.h to take effect. (which > kind of explains my delayed responses :D ) > I know I am missing something here and there should be a better way to do > this. Any other changes (other than pmc_events.h) > can be tested with above 3 steps. You forgot to mention sys/pmc.h, but that was a simple change so you probably haven't had to touch it since your initial patch. The quick and dirty way is to just copy sys/dev/hwpmc/pmc_events.h to /usr/include/dev/hwpmc. Also sys/sys/pmc.h to /usr/include/sys. Thanks, -Jim >> >> Thanks for working on this! > > Entirely my pleasure :-) > > Thanks, > Hiren >