Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 6 Oct 2024 23:23:23 +0200
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Xavier Humbert <xavier@groumpf.org>
Cc:        FreeBSD Ports ML <freebsd-ports@freebsd.org>
Subject:   Re: devel/qt6-tools does not build with LLVM 19
Message-ID:  <29FB0890-BBAA-4EC3-A5C0-8E08D05F11B1@FreeBSD.org>
In-Reply-To: <3b6076fb-3d9b-42e1-a9a6-f15df5409aa7@groumpf.org>
References:  <3b6076fb-3d9b-42e1-a9a6-f15df5409aa7@groumpf.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 6 Oct 2024, at 20:44, Xavier Humbert <xavier@groumpf.org> wrote:
>=20
> I use
> DEFAULT_VERSIONS+=3Dllvm=3D19
> in my /etc/make.conf.
>=20
> devel/qt6-tools does not build :
>=20
> =
/usr/ports/devel/qt6-tools/work/qttools-everywhere-src-6.7.3/src/linguist/=
lupdate/clangtoolastreader.cpp:785:73: error: no member named 'getName' =
in 'clang::FileEntry'
>   785 |     if =
(!LupdatePrivate::isFileSignificant(fullLocation.getFileEntry()->getName()=
.str()))
>=20
> Reverting back to
> DEFAULT_VERSIONS+=3Dllvm=3D18
>=20
> makes it compile fine
>=20
> Read on Chromium forum, same error, reason is :
>=20
>> commit 1b04e6d4a314cf677b5320b26f2746733b11152c
>> Author: Hans Wennborg <hans@chromium.org>
>> Date: Thu Jan 25 13:36:37 2024
>>=20
>> [clang] Remove use of FileEntry::getName()
>>=20
>> That method was dropped recently. Instead, we should get the name via
>> the new FileEntryRef class. That one has existed for a while, so this
>> code works for both pinned and tip-of-tree Clang.

It's better to import the upstream fix, obviously. I have been fixing
llvm 19 related issues such as https://bugs.freebsd.org/281474, but this
looks a little different. It's a bit strange that this error did not
come up during the exp-run for https://bugs.freebsd.org/280562 ?

-Dimitry




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?29FB0890-BBAA-4EC3-A5C0-8E08D05F11B1>