From owner-freebsd-arm@freebsd.org Wed Feb 27 15:50:05 2019 Return-Path: Delivered-To: freebsd-arm@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A3FD152059B; Wed, 27 Feb 2019 15:50:05 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1157283A72; Wed, 27 Feb 2019 15:50:05 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id B682570CF; Wed, 27 Feb 2019 15:50:04 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f175.google.com with SMTP id w6so14400314ljd.7; Wed, 27 Feb 2019 07:50:04 -0800 (PST) X-Gm-Message-State: AHQUAubdn7f1Jq+qk1F/U7zLC/XWHpLbC+FqC8CQN9jLfXynFHFGHzjK /KDeFwd+NtqVfzXvEKT2DzYVifTB96Li5tI9/QY= X-Google-Smtp-Source: APXvYqzN35mUpTbP6GEKYclrcOuTzpnkJlk4i7eZ9XwWfkknUiRhLjSdfO3EiKBpp28qlwc4vwE0BRyh+gVTLiaa5Bk= X-Received: by 2002:a2e:9ec2:: with SMTP id h2mr1840737ljk.186.1551282603153; Wed, 27 Feb 2019 07:50:03 -0800 (PST) MIME-Version: 1.0 References: <20190227035542.GA60321@www.zefox.net> <4c983cf9d039bf95bd19433cbf640f2ae68b0580.camel@freebsd.org> <8ecba76475a9e59f966e4db6e52e36a171bf0707.camel@freebsd.org> In-Reply-To: <8ecba76475a9e59f966e4db6e52e36a171bf0707.camel@freebsd.org> From: Kyle Evans Date: Wed, 27 Feb 2019 09:49:32 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Kernel build failure on rpi2 at 344613 To: Ian Lepore Cc: Kyle Evans , freebsd-testing@freebsd.org, "freebsd-arm@freebsd.org" , Li-Wen Hsu Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1157283A72 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.96 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.97)[-0.966,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 15:50:05 -0000 On Wed, Feb 27, 2019 at 9:44 AM Ian Lepore wrote: > > On Wed, 2019-02-27 at 07:00 -0600, Kyle Evans wrote: > > On Tue, Feb 26, 2019 at 11:06 PM Ian Lepore wrote: > > > > > > On Tue, 2019-02-26 at 19:55 -0800, bob prohaska wrote: > > > > In trying to make world and kernel on RPI2 at r344613 buildworld > > > > ran > > > > to > > > > completion, but buildkernel stopped wtih > > > > --- machdep_boot.o --- > > > > /usr/src/sys/arm/arm/machdep_boot.c:170:34: error: too few > > > > arguments > > > > to function call, single argument 'cmdline' was not specified > > > > boothowto |= boot_parse_cmdline(); > > > > ~~~~~~~~~~~~~~~~~~ ^ > > > > /usr/src/sys/sys/boot.h:37:1: note: 'boot_parse_cmdline' declared > > > > here > > > > int boot_parse_cmdline(char *cmdline); > > > > ^ > > > > 1 error generated. > > > > *** [machdep_boot.o] Error code 1 > > > > > > > > make[2]: stopped in /usr/obj/usr/src/sys/RPI2 > > > > > > > > The machine is running > > > > FreeBSD www.zefox.com 11.2-STABLE FreeBSD 11.2-STABLE #0 r343555: > > > > Wed > > > > Jan 30 04:55:19 PST 2019 bob@www.zefox.com:/usr/obj/usr/src/s > > > > ys/R > > > > PI2 arm > > > > > > > > Any idea how to get past this impediment? > > > > > > > > Thanks for reading, > > > > > > > > bob prohaska > > > > > > > > > > Fix should be committed soon; to get moving right away, apply this > > > patch: > > > > > > > https://svnweb.freebsd.org/base/head/sys/arm/arm/machdep_boot.c?r1=336244&r2=336262&view=patch > > > > > > > I clearly failed to catch it, but I'm also trying to decide why > > Jenkins' stable/11 job didn't catch it... machdep_boot is standard > > arm*, but the build didn't skip a beat. CC'ing lwhsu@/freebsd- > > testing@ > > because that seems like it might be indicative of a slightly larger > > problem. > > > > In either case, thanks for the pointer! MFC is getting committed > > momentarily. > > _______________________________________________ > > > That code is conditional on option LINUX_BOOT_ABI, but that option > should be on for GENERIC and all rpi builds. > Ahh, I missed that. stable/11's CI build only does BEAGLEBONE IMX6 VIRT; we should add RPI2 or RPI-B to that list to broaden the horizons a bit.