From owner-freebsd-isdn Fri Jan 24 7:22:43 2003 Delivered-To: freebsd-isdn@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3715C37B401; Fri, 24 Jan 2003 07:22:42 -0800 (PST) Received: from mailout03.sul.t-online.com (mailout03.sul.t-online.com [194.25.134.81]) by mx1.FreeBSD.org (Postfix) with ESMTP id 923CA43F5B; Fri, 24 Jan 2003 07:22:34 -0800 (PST) (envelope-from garyj@jennejohn.org) Received: from fwd02.sul.t-online.de by mailout03.sul.t-online.com with smtp id 18c5f7-00073Z-0A; Fri, 24 Jan 2003 16:22:33 +0100 Received: from peedub.jennejohn.org (520017439985-0001@[217.228.218.76]) by fmrl02.sul.t-online.com with esmtp id 18c5ev-1QSFPMC; Fri, 24 Jan 2003 16:22:21 +0100 Received: from peedub.jennejohn.org (localhost [127.0.0.1]) by peedub.jennejohn.org (8.12.6/8.11.6) with ESMTP id h0OFLwj1014253; Fri, 24 Jan 2003 16:22:10 +0100 (CET) (envelope-from garyj@peedub.jennejohn.org) Message-Id: <200301241522.h0OFLwj1014253@peedub.jennejohn.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.3 To: "Ari Suutari" Cc: "G Hasse" , joerg@freebsd.org, freebsd-isdn@freebsd.org Subject: Re: Problem with "no bufferspace" - solution Reply-To: Gary Jennejohn In-reply-to: Your message of "Fri, 24 Jan 2003 15:36:01 +0200." <000b01c2c3ad$8d0615e0$0235a8c0@raisa> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Date: Fri, 24 Jan 2003 16:21:58 +0100 From: Gary Jennejohn X-Sender: 520017439985-0001@t-dialin.net Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org "Ari Suutari" writes: > > Gary Jennejohn writes: > > > #if 0 > > > /* we assume STATE_INITIAL here! */ > > > /* these lines kept for information only */ > > > if (sp->state[IDX_LCP] != STATE_INITIAL) > > > lcp.Close(sp); > > > #endif > > Layer is not in initial state, it is in starting state. > So this code should be executed here. The only > problem is that it references many internal defines > of if_spppsubr.c. Wouldn't it be easier to make > lcp_down if if_spppsubr.c smarter so it wouldn't > complain like it now does ? > [Note: 2 mails handled in one] In that case my suggestion is incorrect. Your patch is the correct way to do it. "Ari Suutari" writes: > I did some reading on PPP RFC (1661). The correct way for > physical layer to signal that it is no longer able to carry packet > is to use Down event. So I think that my original code was correct. > The problem is in sppp layer, which works otherwise ok > but prints out extraneous message. > > The PPP RFC doesn't say that it is legal to receive > Down event when LCP is in starting state but says > elsewhere that Down is the event to use by physical layer... I suppose. if_spppsubr.c is Jörg Wunsch's baby. We should ask him his opinion. I'm pretty sure that he's subscribed to this list. But I'll Cc: him. Jörg, any problem aith adding something like this to sppp_down_event? (not a real diff) case STATE_CLOSING: + case STATE_STARTING: sppp_cp_change_state(cp, sp, STATE_INITIAL); break; --- Gary Jennejohn / garyj@jennejohn.org gj@freebsd.org gj@denx.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message