From owner-freebsd-hackers Wed Mar 6 0:56:37 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 2D2A337B405; Wed, 6 Mar 2002 00:56:35 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id g268uTp07014; Wed, 6 Mar 2002 00:56:29 -0800 (PST) (envelope-from obrien) Date: Wed, 6 Mar 2002 00:52:25 -0800 From: "David O'Brien" To: Mike Meyer Cc: Giorgos Keramidas , hackers@freebsd.org Subject: Re: RFC: style(9) isn't explicit about booleans for testing. Message-ID: <20020306005225.A6921@dragon.nuxi.com> Reply-To: obrien@freebsd.org References: <20020305201350.GC4820@hades.hell.gr> <20020305155850.A38095@dragon.nuxi.com> <20020306000806.GC6839@hades.hell.gr> <20020305164054.B38095@dragon.nuxi.com> <15493.49923.458997.98416@guru.mired.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <15493.49923.458997.98416@guru.mired.org>; from mwm-dated-1015831171.a21ab0@mired.org on Wed, Mar 06, 2002 at 01:19:31AM -0600 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Mar 06, 2002 at 01:19:31AM -0600, Mike Meyer wrote: > David O'Brien types: > > On Wed, Mar 06, 2002 at 02:08:07AM +0200, Giorgos Jeremiahs wrote: > > I was giving one. :-) > > style(9) documents the practices of /sys. Thus we should not arbitaryly > > add rules w/o them being backed up in code. > > As the original author of the PR, I'll point out that this chagne does > *not* add rules. It clarifies the wording of a rule that's already > there. If the rule is wrong, it should be removed. The reason I didn't > post if for wider review was because it wasn't changing any rules. My > thanks to Giorgos for moving this PR towards closure. I don't think it is clarifying a rule. I think it is in fact adding a rule. You are extrapolating too much I think. All the rule is trying to prevent is "if (!strcmp(a,b))" which when read is extremely wrong of that is actually happening. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message