From owner-svn-src-head@FreeBSD.ORG Fri Dec 28 07:53:00 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DC3F2ED6 for ; Fri, 28 Dec 2012 07:53:00 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-gg0-f181.google.com (mail-gg0-f181.google.com [209.85.161.181]) by mx1.freebsd.org (Postfix) with ESMTP id 8E2418FC08 for ; Fri, 28 Dec 2012 07:53:00 +0000 (UTC) Received: by mail-gg0-f181.google.com with SMTP id s6so1659960ggc.12 for ; Thu, 27 Dec 2012 23:52:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=WRT0Q4fhaF3Cho5ineLHlxa+M7MpoJqLId666yuhseM=; b=bCha5jn7KWVvpe5Y5tw/48RNZljxP9ENIT9afjdFYmIXNBFyFlNrrduWogcwmGLeM+ kuIZ1NWHgFLkNELknnACV5mwetSlufLlre9vgQVORXxbj6JKj7sgk9AvATorV+6LRTGQ U5uSjZa/rupAIxYmCQgGy1MCoAYWDrCjIUWoFAj9CEVBfmwEMrmCjPZW9D1LriuX/ecq hNCH2BvS0X8AKQAKsmTN4cp9d583+YcxWnKlb10FrsAGFMxX9tlMaeRU1lmpKI3eQb+Z aLAnb9lL4WeBCLYI5nv1pUauCQiqExge5xs+Xvs0RKQtWpSFoZXCgJnTO6PSG5BvvSHJ ObHQ== Received: by 10.236.137.172 with SMTP id y32mr28662925yhi.124.1356680763505; Thu, 27 Dec 2012 23:46:03 -0800 (PST) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.147.119.38 with HTTP; Thu, 27 Dec 2012 23:45:43 -0800 (PST) In-Reply-To: <201212280652.qBS6qrj7072246@svn.freebsd.org> References: <201212280652.qBS6qrj7072246@svn.freebsd.org> From: Juli Mallett Date: Thu, 27 Dec 2012 23:45:43 -0800 X-Google-Sender-Auth: 0zW-SNbbf7Wg1g1fn1VOOJDvvtQ Message-ID: Subject: Re: svn commit: r244765 - in head/sys: kern tools To: Oleksandr Tymoshenko Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQl19of3zFkwZo2wsoCqtMX/6TXyCZkYDTYFpky8SITzS6D+O78Gwc8442thZbtukP8S/TTT Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2012 07:53:00 -0000 Seems like uintmax_t and %ju might be better? At least, truncating a syscall arg to a pointer seems like it could be misleading (e.g. on MIPS n32, even though it's an abomination.) On Thu, Dec 27, 2012 at 10:52 PM, Oleksandr Tymoshenko wrote: > Author: gonzo > Date: Fri Dec 28 06:52:53 2012 > New Revision: 244765 > URL: http://svnweb.freebsd.org/changeset/base/244765 > > Log: > Fix build on ARM (and probably other platforms) > > Modified: > head/sys/kern/subr_syscall.c > head/sys/tools/vnode_if.awk > > Modified: head/sys/kern/subr_syscall.c > ============================================================================== > --- head/sys/kern/subr_syscall.c Fri Dec 28 05:48:44 2012 (r244764) > +++ head/sys/kern/subr_syscall.c Fri Dec 28 06:52:53 2012 (r244765) > @@ -78,7 +78,7 @@ syscallenter(struct thread *td, struct s > ktrsyscall(sa->code, sa->narg, sa->args); > #endif > KTR_START4(KTR_SYSC, "syscall", syscallname(p, sa->code), > - td, "pid:%d", td->td_proc->p_pid, "arg0:%p", sa->args[0], > + (uintptr_t)td, "pid:%d", td->td_proc->p_pid, "arg0:%p", sa->args[0], > "arg1:%p", sa->args[1], "arg2:%p", sa->args[2]); > > if (error == 0) { > @@ -152,7 +152,7 @@ syscallenter(struct thread *td, struct s > } > retval: > KTR_STOP4(KTR_SYSC, "syscall", syscallname(p, sa->code), > - td, "pid:%d", td->td_proc->p_pid, "error:%d", error, > + (uintptr_t)td, "pid:%d", td->td_proc->p_pid, "error:%d", error, > "retval0:%#lx", td->td_retval[0], "retval1:%#lx", > td->td_retval[1]); > if (traced) { > > Modified: head/sys/tools/vnode_if.awk > ============================================================================== > --- head/sys/tools/vnode_if.awk Fri Dec 28 05:48:44 2012 (r244764) > +++ head/sys/tools/vnode_if.awk Fri Dec 28 06:52:53 2012 (r244765) > @@ -270,7 +270,7 @@ while ((getline < srcfile) > 0) { > ctrargs = 4; > else > ctrargs = numargs; > - ctrstr = ctrargs "(KTR_VOP, \"VOP\", \"" uname "\", a,\n\t "; > + ctrstr = ctrargs "(KTR_VOP, \"VOP\", \"" uname "\", (uintptr_t)a,\n\t "; > ctrstr = ctrstr "\"" args[0] ":0x%jX\", (uintptr_t)a->a_" args[0]; > for (i = 1; i < ctrargs; ++i) > ctrstr = ctrstr ", \"" args[i] ":0x%jX\", a->a_" args[i];