Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 19 Jun 2020 10:24:28 +0200
From:      =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org>
To:        Adam Weinberger <adamw@adamw.org>
Cc:        ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>,  svn-ports-head <svn-ports-head@freebsd.org>
Subject:   Re: svn commit: r539531 - in head/security: . vigenere
Message-ID:  <CAGwOe2aZdDkEYQgCzqwDcoH3ZXvLf=Mmr9cXO0Fu7WMjnUOCcw@mail.gmail.com>
In-Reply-To: <CAP7rwch%2B9YQNrMbpHqLPv8VzgDsJhZVm586y4pRn%2BGM6kXL5SA@mail.gmail.com>
References:  <202006180657.05I6viix040418@repo.freebsd.org> <CAP7rwch%2B9YQNrMbpHqLPv8VzgDsJhZVm586y4pRn%2BGM6kXL5SA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 19, 2020 at 8:49 AM Adam Weinberger <adamw@adamw.org> wrote:
>
> On Thu, Jun 18, 2020 at 12:57 AM Fernando Apestegu=C3=ADa
> <fernape@freebsd.org> wrote:
> >
> > Author: fernape
> > Date: Thu Jun 18 06:57:44 2020
> > New Revision: 539531
> > URL: https://svnweb.freebsd.org/changeset/ports/539531
> >
> > Log:
> >   new port: security/vigenere: cipher algorithm tool
> >
> >   vigenere is an implementation of the Vigenere cipher algorithm extend=
ed
> >   to the entire set of printable ASCII characters
> >
> >   https://www.olivermahmoudi.com/programming/vigenere-cipher/
> >
> >   PR:   247244
> >   Submitted by: fbsd@olivermahmoudi.com
> >
> > Added:
> >   head/security/vigenere/
> >   head/security/vigenere/Makefile   (contents, props changed)
> >   head/security/vigenere/distinfo   (contents, props changed)
> >   head/security/vigenere/pkg-descr   (contents, props changed)
> > Modified:
> >   head/security/Makefile
> >
> > Modified: head/security/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/security/Makefile      Thu Jun 18 06:57:40 2020        (r53953=
0)
> > +++ head/security/Makefile      Thu Jun 18 06:57:44 2020        (r53953=
1)
> > @@ -1259,6 +1259,7 @@
> >      SUBDIR +=3D vanguards-tor
> >      SUBDIR +=3D vault
> >      SUBDIR +=3D veracrypt
> > +    SUBDIR +=3D vigenere
> >      SUBDIR +=3D vinetto
> >      SUBDIR +=3D vlock
> >      SUBDIR +=3D vm-to-tor
> >
> > Added: head/security/vigenere/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> > +++ head/security/vigenere/Makefile     Thu Jun 18 06:57:44 2020       =
 (r539531)
> > @@ -0,0 +1,24 @@
> > +# $FreeBSD$
> > +
> > +PORTNAME=3D      vigenere
> > +PORTVERSION=3D   1.0
> > +CATEGORIES=3D    security
> > +MASTER_SITES=3D  http://www.olivermahmoudi.com/files/
> > +
> > +MAINTAINER=3D    fbsd@olivermahmoudi.com
> > +COMMENT=3D       Vigenere cipher cryptography tool
> > +
> > +LICENSE=3D       BSD2CLAUSE
> > +LICENSE_FILE=3D  ${WRKSRC}/LICENSE
> > +
> > +PLIST_FILES=3D   bin/vigenere \
> > +               man/man1/vigenere.1.gz
> > +
> > +do-build:
> > +       cd ${WRKSRC} && ${CC} ${CFLAGS} ${LDFLAGS} -o ${PORTNAME} ${POR=
TNAME}.c
> > +
> > +do-install:
> > +       ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${STAGEDIR}${PREFIX}/b=
in
> > +       ${INSTALL_MAN} ${WRKSRC}/${PORTNAME}.1 ${STAGEDIR}${PREFIX}/man=
/man1
> > +
> > +.include <bsd.port.mk>
> >
> > Added: head/security/vigenere/distinfo
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> > +++ head/security/vigenere/distinfo     Thu Jun 18 06:57:44 2020       =
 (r539531)
> > @@ -0,0 +1,3 @@
> > +TIMESTAMP =3D 1592095290
> > +SHA256 (vigenere-1.0.tar.gz) =3D 96bc7dc9b582a36ec020cee47f9840065b7be=
b53ef8d5b68962643077b6c0b6b
> > +SIZE (vigenere-1.0.tar.gz) =3D 5618
> >
> > Added: head/security/vigenere/pkg-descr
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> > +++ head/security/vigenere/pkg-descr    Thu Jun 18 06:57:44 2020       =
 (r539531)
> > @@ -0,0 +1,6 @@
> > +vigenere is an implementation of the Vigenere cipher encryption
> > +algorithm with an extension to all printable ASCII characters.
> > +The utility is capable of encrypting/decrypting arguments that
> > +are passed to it upon invocation or process input- and outputfiles.
> > +
> > +WWW: https://www.olivermahmoudi.com/programming/vigenere-cipher/
>
> Hi Fernando,
>
> That WWW is 404, and there's no mention of the software on Oliver's websi=
te.

Hi Adam!

I'm pretty sure I checked that, but maybe I missed it?. I will open a
PR asking him about it.

>
> Is this cipher actively used for modern practical purposes? If not,
> this sounds like a programming exercise and I'm not sure why it'd need
> a port.

Before including the new port I checked Oliver was the maintainer of
other ports, some of which I had incidentally committed to recently
(sysutils/mapdir).
Some of his ports include security/caesarcipher that I assume nobody
uses for modern practical purposes either :-) It also happens he is
the original writer of the four ports he maintains.

I read the Committers Guide about new ports
(https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/arti=
cle.html#ports-qa-adding)
in search of policy but couldn't find any.

Should submitters "make a case" for the new port to be included?
Should the committer refuse if he/she evaluates the software is not
useful enough?

Cheers.
>
> # Adam
>
>
> --
> Adam Weinberger
> adamw@adamw.org
> https://www.adamw.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2aZdDkEYQgCzqwDcoH3ZXvLf=Mmr9cXO0Fu7WMjnUOCcw>