From owner-svn-src-head@freebsd.org  Tue Aug  4 04:24:23 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A474A9B34CF;
 Tue,  4 Aug 2015 04:24:23 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 16F559D9;
 Tue,  4 Aug 2015 04:24:22 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t744OAjp070779
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Tue, 4 Aug 2015 07:24:11 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t744OAjp070779
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id t744OAkr070778;
 Tue, 4 Aug 2015 07:24:10 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Tue, 4 Aug 2015 07:24:10 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Benjamin Kaduk <bjkfbsd@gmail.com>
Cc: Edward Tomasz Napierala <trasz@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject: Re: svn commit: r286236 - head/share/man/man9
Message-ID: <20150804042410.GH2072@kib.kiev.ua>
References: <201508031630.t73GUmBR092976@repo.freebsd.org>
 <CAJ5_RoDy=zxpuL8qZQM04EEaRAd_hfjDTyqeYaq6nZmvS5w+Vg@mail.gmail.com>
 <20150804041650.GG2072@kib.kiev.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150804041650.GG2072@kib.kiev.ua>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Aug 2015 04:24:23 -0000

On Tue, Aug 04, 2015 at 07:16:50AM +0300, Konstantin Belousov wrote:
> On Mon, Aug 03, 2015 at 01:52:46PM -0400, Benjamin Kaduk wrote:
> > On Mon, Aug 3, 2015 at 12:30 PM, Edward Tomasz Napierala <trasz@freebsd.org>
> > wrote:
> > 
> > > Author: trasz
> > > Date: Mon Aug  3 16:30:47 2015
> > > New Revision: 286236
> > > URL: https://svnweb.freebsd.org/changeset/base/286236
> > >
> > > Log:
> > >   Document vgonel(9).
> > >
> > 
> > Er, isn't this a step backwards?
> > 
> > % static void     vgonel(struct vnode *);
> > 
> > It is only accidental that anything outside vfs_subr.c can call vgonel().
> Indeed, only kernel modules on some architectures could use a hole in
> the kernel linker to reference vgonel(). The kernel itself cannot call
> vgonel() outside vfs_subr.c. There is no point in putting vgonel(9) in
> the man page.

I believe the source of the confusion is the vgonel() definition, which
lacks the static qualifier.  I propose to remove vgonel(9) reference from
the man page and add static to definition.

Might be, a review of all functions in vfs_*.c and fixing their missed
qualifiers would be useful.