From nobody Mon Aug 3 11:16:58 2026 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hDDf221gbz6n90f for ; Mon, 03 Aug 2026 11:16:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hDDf218xhz3LGk for ; Mon, 03 Aug 2026 11:16:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785755818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sTbdnVkU17Hwy75JIOJVTN1a5WKJEd+jdlB4dqZewmo=; b=oiAD3YBml5NIt+vQ7e+1UWiSPm2Dwj8fht9Bp6ef1N+rYIiSja8cucA73tWkKynStmXImF vkoAUFLDgAkG1A+9aDoBSr4meCD4TGICzsB5RlO2MjDCP2vdmYumnCtVPFi43J49cYHE3h Yb8xDbWuudsVcgnhY85hlEvIdAMS2ihqVKrw1YA8VoUlnwCVmu1/mBsTY7L8EaQ17SV38n Jghw9mA6j3iAlhYfXOhqJ64tvJY5Kie1mph+G7GdWCD40AeGmszxZGFeZAptra2YTbT1Zm DwPFfkH7lCczephoN5xHXfalHLIo/ZB8xkiz1sFLETgnI3CNLd3PQ3IdTnsKoA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785755818; a=rsa-sha256; cv=none; b=wYN8CNIOkp1AiPIXtnAzggrNZfKzevw9rNG+XRqBkR7YVOprQk6t9t6eATy9jpDa2EIGQO yfS1JGXRm+Lw85YyBcrDMO4sk3s9yJwIiZbEZyMpT7jUH0FE9rx6KBL9XCWurqaU22OZd3 h0iz4GjZFtJuM+61scMB/7GgGra/6GtqlZ2r5Ll5ixPAuttOQybNP6XwLhz9KcQuzirqAT Wzo/6P8VwD5NVAjQTh5CyP2REzDYfnlGxbyGVdtpph3M7VnukGlsry6Pdz9BL/xoLetCWw 22yRM/oKV8ZhrDB9WJQEpliWB7tCUkJEh4ydpGr7gdyHyQIEi4MX9vl0FUGI3w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785755818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sTbdnVkU17Hwy75JIOJVTN1a5WKJEd+jdlB4dqZewmo=; b=wy7w+f7foXmIdVS6lx1Lytp/PKWhnum+CVC2j1Do+T2WzoYyEcdliJ6+nNTbW1PUlKVgIL B3GwaoiGqp8S8ttIX+q4siO/GwQMgSNdrXQ9fbM1UdReEpW6B8JYhi8bI80Oi79K9ZWkU7 02BnD2HuudajHekunelYDofZahrKPDgr2Q6C82gAkB2Vmqdtw8uJoRVwAl00SeU6RRcGks Gb87s2geS9h0rWt8EF7G6zBH5pzGW6nhS5ZFNfnPu3WtlavvOkO2cAyhL5EIXinsFh32Fw 6CFA9fgYqKuL6/zos4TLIIFqMyQZVseolPzwZUyqXn+xTdWpYeX0kULJ5VMxCA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4hDDf201dbzyLn for ; Mon, 03 Aug 2026 11:16:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 673BGvVf013046 for ; Mon, 3 Aug 2026 11:16:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 673BGvlP013045 for net@FreeBSD.org; Mon, 3 Aug 2026 11:16:57 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 296594] TCP: RFC 5961 sends a challenge ACK instead of resetting when a valid RST arrives with SEG.SEQ == RCV.NXT and the receiver has delayed-ACKed data, leaving the connection half-open Date: Mon, 03 Aug 2026 11:16:58 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 16.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D296594 --- Comment #9 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc9df1a6cf9be9d44eacc8616ebba1cd19= 010c7fc commit c9df1a6cf9be9d44eacc8616ebba1cd19010c7fc Author: Michael Tuexen AuthorDate: 2026-08-03 11:07:32 +0000 Commit: Michael Tuexen CommitDate: 2026-08-03 11:07:32 +0000 tcp: improve SEG.SEQ validation for RST segments A RST segment can be sent in response to (a) received segment or (b) by the upper layer protocol. The SEG.SEQ validation consists of two checks: (1) the in-window check of SEG.SEQ and (2) the exact match check of SEG.SEQ. For the in-window check (1), the left edge of the window needs to be based on tp->last_ack_sent to cover the delayed ACK case, whereas the right edge needs to be based on tp->rcv_nxt + tp->rcv_wnd. This both assumes that tp->rcv_wnd is not zero. For the special case of tp->rcv_wnd being zero, add checks against tp->last_ack_sent for (a) and on tp->rcv_nxt for (b). This applies to all TCP stacks. When the exact match (2) of SEG.SEQ is performed, it should be based on tp->last_ack_sent for (a) and on tp->rcv_nxt for (b). To cover both, check for both. Add this only to the base stack, since the RACK and BBR stacks already do this. PR: 296594 Reviewed by: rscheff MFC after: 3 days MFC to: stable/14 MFC to: stable/15 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D58594 sys/netinet/tcp_input.c | 18 ++++++++++++------ sys/netinet/tcp_stacks/rack_bbr_common.c | 22 ++++++++++++++-------- 2 files changed, 26 insertions(+), 14 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=