Date: Tue, 25 Nov 2008 00:55:38 +0200 From: Manolis Kiagias <sonic2000gr@gmail.com> To: =?ISO-8859-1?Q?G=E1bor_K=F6vesd=E1n?= <gabor@kovesdan.org> Cc: Tom Rhodes <trhodes@FreeBSD.org>, doc@FreeBSD.org, pgj@FreeBSD.org, keramida@FreeBSD.org, remko@FreeBSD.org Subject: Re: A patch for the 'geom' chapter Message-ID: <492B30EA.5040807@gmail.com> In-Reply-To: <492B2FCF.5060503@kovesdan.org> References: <492AE607.4020208@gmail.com> <20081124135107.06a8af26.trhodes@FreeBSD.org> <87abbp3q5o.fsf@kobe.laptop> <492B01C4.6090707@gmail.com> <e890cae60811241157p520238a2k4403f13cf340e403@mail.gmail.com> <20081124153358.7a539e67.trhodes@FreeBSD.org> <492B2D8C.4090807@gmail.com> <492B2FCF.5060503@kovesdan.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Gábor Kövesdán wrote: > Manolis Kiagias escribió: >> After our discussion, here again is the "second take" of this patch: >> >> http://people.freebsd.org/~manolis/geom.txt >> >> And the build starts here: >> >> http://people.freebsd.org/~manolis/geom.html >> >> I tried to address most points, but feel free to send more comments and >> fixes. >> Take your time, as I won't be looking at this further tonight (it will >> only get worse if I do ;) ) >> > Hi Manolis, > > I've reviewed this second patch. Nice work, thanks for your efforts! I > only found a little nit: > > + <filename>geom_journal.ko</filename> kernel will also have to be > > > > It should be "kernel module" instead of "kernel". > > Cheers, > Aha, this is indeed too small and I will fix immediately ;) Thanks!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?492B30EA.5040807>