From owner-freebsd-current Sun Mar 24 14:16:33 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id OAA27602 for current-outgoing; Sun, 24 Mar 1996 14:16:33 -0800 (PST) Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id OAA27586 for ; Sun, 24 Mar 1996 14:16:23 -0800 (PST) Received: from sax.sax.de by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id UAA29936 for ; Sun, 24 Mar 1996 20:50:16 +0200 Received: by sax.sax.de (8.6.11/8.6.12-s1) with UUCP id TAA29491 for freebsd-current@FreeBSD.org; Sun, 24 Mar 1996 19:50:16 +0100 Received: (from j@localhost) by uriah.heep.sax.de (8.7.4/8.6.9) id TAA04491 for freebsd-current@FreeBSD.org; Sun, 24 Mar 1996 19:05:26 +0100 (MET) From: J Wunsch Message-Id: <199603241805.TAA04491@uriah.heep.sax.de> Subject: Re: fseek To: freebsd-current@freebsd.org (FreeBSD-current users) Date: Sun, 24 Mar 1996 19:05:26 +0100 (MET) Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <199603241346.NAA02266@originat.demon.co.uk> from "Paul Richards" at Mar 24, 96 01:46:31 pm X-Phone: +49-351-2012 669 X-Mailer: ELM [version 2.4 PL24 ME8a] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk As Paul Richards wrote: > Why has the second paramater of fgets changed from int to size_t ? > > Doesn't the ANSI standard have something to say about this, similarly > ftell has a const added. Our definitions are ``more correct'', but violate ANSI. They have to be changed, or we cannot claim them ANSI compliant. (I've also stumpled across this when importing lint.) > Breaks the building of llib-lstdc but I don't want to change the lint > library since it looks right from my reading of K&R 2 and our files > look wrong. What's the correct thing to do? Btw., since you happen to continue the work on lint... Our libc includes two different ``struct pmap''s. One is the well-known one for the portmapper, the other one sneaked in from the VM code and describes a ``page map'' (or something like this). We need to change one of them, most likely the latter one, in order to ever get libc linted. I've once tried to add a ``pmap_t'' typedef for the latter type, but broke everything with it, since i've apparently overlooked something. This was about the point where i've stopped attempting to get lint fully included. More nits back from the old days (might or might not still apply): has definitions of the form: #define ntohl __byte_swap_long ...but needs to also get prototypes for the functions, perhaps an #ifdef __lint might help. redefines TRUE and FALSE, without protecting them by an #ifndef. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)