Date: Mon, 10 Jul 1995 17:36:15 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> To: joerg_wunsch@uriah.heep.sax.de Cc: roberto@keltia.freenix.fr, freebsd-current@freebsd.org Subject: Re: gnu/usr.bin/texinfo/Makefile.inc Message-ID: <199507110036.RAA14743@gndrsh.aac.dev.com> In-Reply-To: <199507101420.QAA01371@uriah.heep.sax.de> from "J Wunsch" at Jul 10, 95 04:20:09 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> > As Rodney W. Grimes wrote: > > > > > > > > Jörg, why are you forcing -O2 in this file for all of texinfo's utilities ? > > > > +CFLAGS+= -O2 -pipe > > > > You confused the heck out of me with this one, this is a modification on > > some machine some place, this modification is part of a recent commit, > > which I did not have pulled out in my source tree. > > > > cvs diff -u -r1.2 -r1.3 showed me it was added recently. This should > > not be there unless there is a VERY good reason for it. Either way > > the -pipe must die, that really kills small machines compiling. > > The -pipe went in by accident. After fiddling a bit around with it, i > didn't find an easy way to fetch the setting out of /etc/make.conf > without breaking the whole (and ugly) make mechanism of texinfo. The > previous state of the art has been _no_ optimization at all, which i > considered bogus. Other than texinfo/misc/Makefile these all include bsd.prog.mk which should already be handling the /etc/make.conf stuff. The real question now is why do all these makefiles explicitly null out CFLAGS then add a bunch of defines to it??? That should be done with setting COPTS, not CFLAGS!!! > If anybody knows a better solution, i'm willing to use it. Otherwise > i would simply go and kill the -pipe. Use COPTS instead of CFLAGS in the bloody makefiles, CFLAGS is global to the tree, COPTS is private to a particular directory. > (Btw., i've not seen Ollivier's message at all.) :-(. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Reliable computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199507110036.RAA14743>