Date: Sun, 26 Jul 2009 15:39:24 +0100 (BST) From: Chris Rees <utisoft@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/137156: Dump cryptic output on reporting progress Message-ID: <200907261439.n6QEdOPR005899@amnesiac.bayofrum.net> Resent-Message-ID: <200907261440.n6QEe1RA036268@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 137156
>Category: bin
>Synopsis: Dump cryptic output on reporting progress
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Jul 26 14:40:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Chris Rees
>Release: FreeBSD 7.2-RELEASE i386
>Organization:
bayofrum.net
>Environment:
System: FreeBSD amnesiac.bayofrum.net 7.2-RELEASE FreeBSD 7.2-RELEASE #1: Sun May 3 21:54:38 BST 2009 root@amnesiac.bayofrum.net:/usr/obj/usr/src/sys/AMNESIAC i386
>Description:
When dump has a large amount of data to process, it gives output like this:
DUMP: finished in 41 seconds, throughput 5475 KBytes/sec
Wouldn't 'finishes' be more appropriate? I've attached a patch to this effect... It took me a while to understand what it meant, and I still think that 'finished' makes no sense.
>How-To-Repeat:
Dump a large filesystem
>Fix:
--- dump.diff begins here ---
--- /usr/src/sbin/dump/optr.c 2006-08-06 15:23:50.000000000 +0100
+++ optr.c 2008-06-08 23:16:44.000000000 +0100
@@ -195,10 +195,10 @@
(void)time(&tnow);
if (blockswritten > tapesize) {
- setproctitle("%s: 99.99%% done, finished soon", disk);
+ setproctitle("%s: 99.99%% done, finishes soon", disk);
if (tnow >= tschedule) {
tschedule = tnow + 300;
- msg("99.99%% done, finished soon\n");
+ msg("99.99%% done, finishes soon\n");
}
} else {
deltat = (blockswritten == 0) ? 0 : tstart_writing - tnow +
@@ -211,13 +211,13 @@
tdone_str = ctime(&tdone);
tdone_str[strlen(tdone_str) - 1] = '\0';
setproctitle(
- "%s: pass %d: %3.2f%% done, finished in %d:%02d at %s",
+ "%s: pass %d: %3.2f%% done, finishes in %d:%02d at %s",
disk, passno, percent, hours, mins, tdone_str);
if (tnow >= tschedule) {
tschedule = tnow + 300;
if (blockswritten < 500)
return;
- msg("%3.2f%% done, finished in %d:%02d at %s\n", percent,
+ msg("%3.2f%% done, finishes in %d:%02d at %s\n", percent,
hours, mins, tdone_str);
}
}
--- dump.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907261439.n6QEdOPR005899>