From owner-cvs-src@FreeBSD.ORG Tue Aug 3 17:00:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DCD0516A4D5 for ; Tue, 3 Aug 2004 17:00:42 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id C105443D5C for ; Tue, 3 Aug 2004 17:00:36 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 19345 invoked from network); 3 Aug 2004 17:00:36 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 3 Aug 2004 17:00:36 -0000 Received: from 10.50.40.208 (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i73H0KPn026940; Tue, 3 Aug 2004 13:00:31 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Nate Lawson Date: Tue, 3 Aug 2004 12:39:06 -0400 User-Agent: KMail/1.6 References: <200408021954.i72JsYD5028875@grimreaper.grondar.org> <410EB74B.7020206@root.org> In-Reply-To: <410EB74B.7020206@root.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200408031239.06942.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: src-committers@FreeBSD.org cc: Brooks Davis cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: David O'Brien cc: Mark Murray Subject: Re: cvs commit: src/sys/modules Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2004 17:00:43 -0000 On Monday 02 August 2004 05:51 pm, Nate Lawson wrote: > Mark Murray wrote: > > Brooks Davis writes: > >>IMO this is a module system bug not a bug in any given module. There's > >> no good reason for the system to succeed at loading a module that's > >> already there regardless of how it got there. I don't understand the > >> module system well enough to know where the bug lies, but I believe the > >> DECLARE_MODULE statement provides more then enough information to avoid > >> duplicates. > > > > I'm looking to see if MODULE_VERSION() may fix this. > > The case where mem is compiled into the kernel and then an attempt is > made to load it as a module needs to be detected by looking for an > instance of the devclass. See how acpi/legacy co-exist. This is not > just a problem with the same module being loaded multiple times. mem is a dev_t aka struct cdev *, not a device_t. There is no devclass. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org