From owner-svn-src-head@FreeBSD.ORG  Thu Sep  3 21:11:13 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 797251065679;
	Thu,  3 Sep 2009 21:11:13 +0000 (UTC) (envelope-from zec@icir.org)
Received: from labs3.cc.fer.hr (labs3.cc.fer.hr [161.53.72.21])
	by mx1.freebsd.org (Postfix) with ESMTP id 07FF58FC16;
	Thu,  3 Sep 2009 21:11:12 +0000 (UTC)
Received: from sluga.fer.hr (sluga.cc.fer.hr [161.53.72.14])
	by labs3.cc.fer.hr (8.13.8+Sun/8.12.10) with ESMTP id n83LB52P014893;
	Thu, 3 Sep 2009 23:11:11 +0200 (CEST)
Received: from localhost ([161.53.19.8]) by sluga.fer.hr with Microsoft
	SMTPSVC(6.0.3790.3959); Thu, 3 Sep 2009 23:11:04 +0200
From: Marko Zec <zec@icir.org>
To: "Jung-uk Kim" <jkim@freebsd.org>
Date: Thu, 3 Sep 2009 23:10:59 +0200
User-Agent: KMail/1.9.10
References: <200909021602.n82G2mpE000812@svn.freebsd.org>
	<200909032225.50210.zec@icir.org>
	<200909031651.49575.jkim@FreeBSD.org>
In-Reply-To: <200909031651.49575.jkim@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200909032310.59837.zec@icir.org>
X-OriginalArrivalTime: 03 Sep 2009 21:11:05.0072 (UTC)
	FILETIME=[0C627700:01CA2CDB]
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r196769 - in head/sys: amd64/amd64 i386/i386
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Sep 2009 21:11:13 -0000

On Thursday 03 September 2009 22:51:47 Jung-uk Kim wrote:
> On Thursday 03 September 2009 04:25 pm, Marko Zec wrote:
> > On Wednesday 02 September 2009 18:02:48 Jung-uk Kim wrote:
> > > Author: jkim
> > > Date: Wed Sep  2 16:02:48 2009
> > > New Revision: 196769
> > > URL: http://svn.freebsd.org/changeset/base/196769
> > >
> > > Log:
> > >   - Work around ACPI mode transition problem for recent NVIDIA
> > > 9400M chipset based Intel Macs.  Since r189055, these platforms
> > > started freezing when ACPI is being initialized for unknown
> > > reason.  For these platforms, we just use the old PAT layout.
> > > Note this change is not enough to boot fully on these platforms
> > > because of other problems but it makes debugging possible. Note
> > > MacBook5,2 may be affected as well but it was not added here
> > > because of lack of hardware to test.
> > >   - Initialize PAT MSR fully instead of reading and modifying it
> > > for safety.
> >
> > Perhaps I'm missing something, but I fail to understand what is the
> > purpose / use of variable pat_tested here?
>
> Without it, bad things may happen while APs are being initialized in
> SMP case.

Ouch, OK, only now I see that pat_tested is declared static - I thought it was 
reset to 0 at each pmap_init_pat() call...

Sorry for the noise,

Marko