From owner-p4-projects@FreeBSD.ORG  Thu Jan 18 14:37:10 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B143A16A521; Thu, 18 Jan 2007 14:37:10 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 8D6B816A51E
	for <perforce@freebsd.org>; Thu, 18 Jan 2007 14:37:10 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 0086E13C468
	for <perforce@freebsd.org>; Thu, 18 Jan 2007 14:37:09 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l0IEaq4m063039;
	Thu, 18 Jan 2007 09:37:05 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Hans Petter Selasky <hselasky@freebsd.org>
Date: Thu, 18 Jan 2007 09:20:22 -0500
User-Agent: KMail/1.9.4
References: <200701181008.l0IA810Z031551@repoman.freebsd.org>
In-Reply-To: <200701181008.l0IA810Z031551@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200701180920.22453.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]);
	Thu, 18 Jan 2007 09:37:05 -0500 (EST)
X-Virus-Scanned: ClamAV 0.88.3/2462/Thu Jan 18 05:07:46 2007 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 113101 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jan 2007 14:37:11 -0000

On Thursday 18 January 2007 05:08, Hans Petter Selasky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=113101
> 
> Change 113101 by hselasky@hselasky_mini_itx on 2007/01/18 10:07:13
> 
> 	If the number of devices changed during list traversal, set
> 	"count" to the lowest value.

There shouldn't be a need for this.  Currently this stuff is protected
by Giant, but at some point in the future it will all be covered with
an sx lock which will basically single-thread most of new-bus including
attach/detach, etc.

> Affected files ...
> 
> .. //depot/projects/usb/src/sys/kern/subr_bus.c#4 edit
> 
> Differences ...
> 
> ==== //depot/projects/usb/src/sys/kern/subr_bus.c#4 (text+ko) ====
> 
> @@ -1876,13 +1876,16 @@
>  	TAILQ_FOREACH(child, &dev->children, link) {
>  		if (n < count) {
>  			list[n] = child;
> -			n++;
>  		}
> +		n++;
>  	}
>  
>  	if (n != count) {
>  		printf("device_get_children: Number of devices changed "
>  		       "from %d to %d!\n", count, n);
> +		if (n < count) {
> +			count = n;
> +		}
>  	}
>  
>  	*devlistp = list;
> 

-- 
John Baldwin