From nobody Sun Dec 26 18:31:14 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5DA73190E7A4; Sun, 26 Dec 2021 18:31:27 +0000 (UTC) (envelope-from michael.tuexen@macmic.franken.de) Received: from drew.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JMTsC1hm5z3Qnj; Sun, 26 Dec 2021 18:31:27 +0000 (UTC) (envelope-from michael.tuexen@macmic.franken.de) Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1140:c3d:3cf6:ba67:d612:3b3c]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 658BF7220BFA5; Sun, 26 Dec 2021 19:31:15 +0100 (CET) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Subject: Re: git: c2c8e360d8c0 - main - tcp: virtualise net.inet.tcp.msl sysctl. From: Michael Tuexen In-Reply-To: Date: Sun, 26 Dec 2021 19:31:14 +0100 Cc: "Alexander V. Chernikov" , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <59738A61-7697-4924-AD10-6C76410961D5@macmic.franken.de> References: <202112261506.1BQF64Cm080930@gitrepo.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 4JMTsC1hm5z3Qnj X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N > On 26. Dec 2021, at 17:20, Gleb Smirnoff wrote: >=20 > On Sun, Dec 26, 2021 at 03:06:04PM +0000, Alexander V. Chernikov = wrote: > A> commit c2c8e360d8c0b8712158d334686d88f052aef819 > A> Author: Alexander V. Chernikov > A>=20 > A> tcp: virtualise net.inet.tcp.msl sysctl. > A> =20 > A> VNET teardown waits 2*MSL (60 seconds by default) before = expiring > A> tcp PCBs. These PCBs holds references to nexthops, which, in = turn, > A> reference ifnets. This chain results in VNET interfaces being = destroyed > A> and moved to default VNET only after 60 seconds. > A> Allow tcp_msl to be set in jail by virtualising = net.inet.tcp.msl sysctl, > A> permitting more predictable VNET tests outcomes. > A> =20 > A> MFC after: 1 week > A> Reviewed by: glebius > A> Differential Revision: https://reviews.freebsd.org/D33270 >=20 > Thanks! Does our test framework use some kind of boilerplate jail = config > so that we can enable smaller MSL for all tests at once? Or does it make more sende to use tcpdrop -s TIME_WAIT to clean up at = the end of the test? Best regards Michael >=20 > --=20 > Gleb Smirnoff