Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Apr 2018 20:33:08 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r332972 - head/sys/x86/x86
Message-ID:  <201804242033.w3OKX8BF034425@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Tue Apr 24 20:33:08 2018
New Revision: 332972
URL: https://svnweb.freebsd.org/changeset/base/332972

Log:
  Extend ap_boot_mtx scope to also cover mca_init().
  
  Otherwise, under bootverbose, the lapic_enable_cmc() banner 'lapicX:
  CMCI unmasked' is printed by several CPUs in parallel, causing garbled
  output for the LAPIC dumps.
  
  Reported by:	royger
  Reviewed by:	jhb
  Sponsored by:	The FreeBSD Foundation
  MFC after:	1 week
  Differential revision:	https://reviews.freebsd.org/D15157

Modified:
  head/sys/x86/x86/mp_x86.c

Modified: head/sys/x86/x86/mp_x86.c
==============================================================================
--- head/sys/x86/x86/mp_x86.c	Tue Apr 24 20:29:40 2018	(r332971)
+++ head/sys/x86/x86/mp_x86.c	Tue Apr 24 20:33:08 2018	(r332972)
@@ -1007,9 +1007,9 @@ init_secondary_tail(void)
 	KASSERT(PCPU_GET(idlethread) != NULL, ("no idle thread"));
 	PCPU_SET(curthread, PCPU_GET(idlethread));
 
-	mca_init();
-
 	mtx_lock_spin(&ap_boot_mtx);
+
+	mca_init();
 
 	/* Init local apic for irq's */
 	lapic_setup(1);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804242033.w3OKX8BF034425>