From owner-svn-src-head@FreeBSD.ORG Thu Feb 23 23:23:12 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by hub.freebsd.org (Postfix) with ESMTP id E9A19106566C; Thu, 23 Feb 2012 23:23:12 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-197-151.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 845B214E707; Thu, 23 Feb 2012 23:23:12 +0000 (UTC) Message-ID: <4F46CA60.6030409@FreeBSD.org> Date: Thu, 23 Feb 2012 15:23:12 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:10.0.2) Gecko/20120218 Thunderbird/10.0.2 MIME-Version: 1.0 To: Andrew Thompson References: <201202232156.q1NLurPU025054@svn.freebsd.org> In-Reply-To: <201202232156.q1NLurPU025054@svn.freebsd.org> X-Enigmail-Version: 1.3.5 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232080 - in head: share/man/man4 sys/net X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2012 23:23:13 -0000 First, I'm always glad to see devs updating the documentation, so please don't take this as in any way being critical, just trying to help. :) On 02/23/2012 13:56, Andrew Thompson wrote: > Modified: head/share/man/man4/lagg.4 > ============================================================================== > --- head/share/man/man4/lagg.4 Thu Feb 23 21:54:04 2012 (r232079) > +++ head/share/man/man4/lagg.4 Thu Feb 23 21:56:53 2012 (r232080) > @@ -142,10 +142,12 @@ and > modes will use the RSS hash from the network card if available to avoid > computing one, this may give poor traffic distribution if the hash is invalid > or uses less of the protocol header information. > -Local hash computation can be forced by setting the > +Local hash computation can be forced per interface by setting the This is a great example of why we use short lines in the man page sources. It allows people to come along later and add text without having to make changes to multiple lines. > .Va net.link.lagg.X.use_flowid > .Xr sysctl 8 > -variable to zero where X is the interface number. > +variable to zero where X is the interface number, the default for > +new interfaces is set via > +.Va net.link.lagg.default_use_flowid . If adding a comma there was the right change the new clause should still have started on the next line, for the reason described above. However, what you added is actually a sentence that can/should stand on its own. hth, Doug -- It's always a long day; 86400 doesn't fit into a short. Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/