From owner-freebsd-current Fri Apr 20 10: 3:45 2001 Delivered-To: freebsd-current@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 2263137B42C; Fri, 20 Apr 2001 10:03:36 -0700 (PDT) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.2/8.11.2) id f3KH3KO57392; Fri, 20 Apr 2001 20:03:20 +0300 (EEST) (envelope-from ru) Date: Fri, 20 Apr 2001 20:03:20 +0300 From: Ruslan Ermilov To: Maxim Sobolev Cc: Konstantin Chuguev , Bruce Evans , current@FreeBSD.org, hackers@FreeBSD.org Subject: Re: [CFR] OpenBSD install(1) fixes: atomic install, etc. Message-ID: <20010420200320.A54192@sunbay.com> Mail-Followup-To: Maxim Sobolev , Konstantin Chuguev , Bruce Evans , current@FreeBSD.org, hackers@FreeBSD.org References: <20010420191008.A51313@sunbay.com> <3AE06267.BE44852F@dante.org.uk> <3AE066C0.6B375985@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3AE066C0.6B375985@FreeBSD.org>; from sobomax@FreeBSD.org on Fri, Apr 20, 2001 at 07:41:36PM +0300 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, Apr 20, 2001 at 07:41:36PM +0300, Maxim Sobolev wrote: > Konstantin Chuguev wrote: > > > Hi, > > > > Ruslan Ermilov wrote: > > > > > The attached patch incorporates most of OpenBSD fixes to install(1). > > > It does not include manpage update. Most significant changes are: > > > > > > o New flag: -S (atomic install) > > > > > > : -S Safe copy. Normally, install unlinks an existing target before > > > : installing the new file. With the -S flag a temporary file is > > > : used and then renamed to be the target. The reason this is safer > > > : is that if the copy or rename fails, the existing target is left > > > : untouched. > > > > > > > Just curious: why not make this way of doing install default (i.e. always use > > it)? > > It may effectively doubles disk space requirements during copy (when destination > file is not on a sofdep-enabled partition and is not open at the moment when > install(8) unlinks it). For small files it doesn't matter, but for a big ones it > could lead to a problem. > I think -S should be made the default for `installworld' (this was the main reason that triggered this work). But I don't think this should be turned `on' by default in install(1). BTW, this binary just completed the `installworld' test on -STABLE. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message