From nobody Mon Jan 12 17:59:39 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dqgBM5HMVz6NtdP for ; Mon, 12 Jan 2026 17:59:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dqgBM2Bv4z3Gdb for ; Mon, 12 Jan 2026 17:59:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768240779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IsXLy62aGwDA8SuvZY/fv98l28KTLiOKMbbNrufH/Vo=; b=yMY478Vbp2GFVYU8h8sI2JWOAe00VPEkUc/RChZPoyBJLwLW7ozs4DKO3Yam7jvU+xz292 4tnslTtbg2oyTkLDKekrYcK/BRjp3ik2dGN6YyOerT+s2wzQvnbMwdwQV0DP2NlS6eqsb8 umBFH6Iim3wxAId0zvhoWyJdG6YQDaqRij0tZpZiPSIeVFmlLH6ktXS+kaZWufICfGvTOe /M5meVO7HWqkCi/MbJULl3MmCEcModqivLqHGka+Pdr/+mtU/3zBtzM2ZGfdaj1lguO//e XiwA/hkytLoLedVoQd9hNVrPjS3lKd39yUy0IRUU30unex0ZpODUsUhGlhKr/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768240779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IsXLy62aGwDA8SuvZY/fv98l28KTLiOKMbbNrufH/Vo=; b=h+Zz/CdPVatPovNnoqmTM2bhXQaoKeDWYZPOxm73QnZOr0YfW45Kjc9i0SBBLFJWosF4/I u9AAWQmQ1bRndc0pXh0MP4bKgR2sEDb+kQShXvnhvQgluAApvuD/t19d1piE4RzmlCxLxv KyE2vNh9jfUstsRlMYqVbVJS5qdcRArOLn8PBH6mszBH8eGvZ6uggn/GenCsqWH6shsDVx O24H0mFFlgvhIXaYGGBpg0ekhvqvZcB6RtdSLOUElAqHDQhdspwVo7l15d+4CbWeYilFI4 6bBKIwhlR9X039LsLpIT/fKspqO+m+yZOiJs/JjcFKUOGASP3JHLFJ8fZTUc9w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768240779; a=rsa-sha256; cv=none; b=Kz+n6ei7kGHu8czyyIReFLbz8IDz/99Lcbanleq7RFbW/ums79tMeDq1IGXAzRRBpY3oqz nU+ofxP0sa69rI9ih622G90kHBuBF+DUcD8HaevLs3F56y1mnCSr9ZR24YS0xhsOLMD7KK Iu+T9VGJdlorP8qPktz4WU1Tf4BznA1is+cvP2GLY8YtPZgGREDiSjNaEUFRlO6bm/dSd3 Tu2C8KfHOKkQ4U1uniVkeWEWO5/dMBbkbAIqyahunUTwyiYFm60aEg0lFJha11sZUQsna1 W6DZW7dt5OptPHWxM+hxpMjND+IgWyo1CiAodUt1KpXOPGSTfHcrJbXu71T05g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dqgBM1QcnzdDX for ; Mon, 12 Jan 2026 17:59:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3be0e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 12 Jan 2026 17:59:39 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 74bb8b966381 - stable/15 - zfs: emit .note.GNU-stack section for all ELF targets List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 74bb8b966381e5ada69ea188f73427334f0b3b7b Auto-Submitted: auto-generated Date: Mon, 12 Jan 2026 17:59:39 +0000 Message-Id: <6965368b.3be0e.ea4ef41@gitrepo.freebsd.org> The branch stable/15 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=74bb8b966381e5ada69ea188f73427334f0b3b7b commit 74bb8b966381e5ada69ea188f73427334f0b3b7b Author: Dimitry Andric AuthorDate: 2026-01-08 08:35:13 +0000 Commit: Dimitry Andric CommitDate: 2026-01-12 17:58:28 +0000 zfs: emit .note.GNU-stack section for all ELF targets On FreeBSD, linking the zfs kernel module with binutils ld 2.44 shows the following warning: ld: warning: aesni-gcm-avx2-vaes.o: missing .note.GNU-stack section implies executable stack ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker Some of the `.S` files under `module/icp/asm-x86_64/modes` check whether to emit the `.note.GNU-stack` section using: #if defined(__linux__) && defined(__ELF__) We could add `&& defined(__FreeBSD__)` to the test, but since all other `.S` files in the OpenZFS tree use: #ifdef __ELF__ it would seem more logical to use that instead. Any recent ELF platform should support these note sections by now. Reviewed by: emaste, kib, imp MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D54578 (cherry picked from commit eb1b6ec7a79aff05f5f10e1d6b1c63a0d8dc5f2f) --- sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-avx2-vaes.S | 2 +- sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S | 2 +- sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-avx2-vaes.S b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-avx2-vaes.S index 3d1b045127e2..76ced8ebad3d 100644 --- a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-avx2-vaes.S +++ b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-avx2-vaes.S @@ -1316,7 +1316,7 @@ SET_SIZE(aes_gcm_dec_update_vaes_avx2) #endif /* !_WIN32 || _KERNEL */ /* Mark the stack non-executable. */ -#if defined(__linux__) && defined(__ELF__) +#ifdef __ELF__ .section .note.GNU-stack,"",%progbits #endif diff --git a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S index 49671f1fc46a..2e0a88ec8cef 100644 --- a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S +++ b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S @@ -1275,7 +1275,7 @@ SECTION_STATIC #endif /* Mark the stack non-executable. */ -#if defined(__linux__) && defined(__ELF__) +#ifdef __ELF__ .section .note.GNU-stack,"",%progbits #endif diff --git a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S index 319caa4e190b..6c5bbf0fb272 100644 --- a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S +++ b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S @@ -714,7 +714,7 @@ SET_OBJ(.Lrem_8bit) .balign 64 /* Mark the stack non-executable. */ -#if defined(__linux__) && defined(__ELF__) +#ifdef __ELF__ .section .note.GNU-stack,"",%progbits #endif