From owner-svn-src-head@FreeBSD.ORG Wed Dec 18 04:52:30 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CBAA81D5; Wed, 18 Dec 2013 04:52:30 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B7C651237; Wed, 18 Dec 2013 04:52:30 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id rBI4qUo2019170; Wed, 18 Dec 2013 04:52:30 GMT (envelope-from marcel@svn.freebsd.org) Received: (from marcel@localhost) by svn.freebsd.org (8.14.7/8.14.7/Submit) id rBI4qURt019169; Wed, 18 Dec 2013 04:52:30 GMT (envelope-from marcel@svn.freebsd.org) Message-Id: <201312180452.rBI4qURt019169@svn.freebsd.org> From: Marcel Moolenaar Date: Wed, 18 Dec 2013 04:52:30 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r259540 - head/lib/libstand X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Dec 2013 04:52:30 -0000 Author: marcel Date: Wed Dec 18 04:52:30 2013 New Revision: 259540 URL: http://svnweb.freebsd.org/changeset/base/259540 Log: Clear f_rabuf after freeing the memory it points to. This prevents a possible double free. Obtained from: Juniper Networks, Inc. Modified: head/lib/libstand/close.c Modified: head/lib/libstand/close.c ============================================================================== --- head/lib/libstand/close.c Wed Dec 18 04:44:38 2013 (r259539) +++ head/lib/libstand/close.c Wed Dec 18 04:52:30 2013 (r259540) @@ -75,8 +75,10 @@ close(int fd) errno = EBADF; return (-1); } - if (f->f_rabuf != NULL) + if (f->f_rabuf != NULL) { free(f->f_rabuf); + f->f_rabuf = NULL; + } if (!(f->f_flags & F_RAW) && f->f_ops) err1 = (f->f_ops->fo_close)(f); if (!(f->f_flags & F_NODEV) && f->f_dev)