From owner-freebsd-arch Thu Dec 13 19:17:55 2001 Delivered-To: freebsd-arch@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 3160937B417; Thu, 13 Dec 2001 19:17:52 -0800 (PST) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.5) with SMTP id fBE3Hoi77716; Thu, 13 Dec 2001 22:17:50 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Thu, 13 Dec 2001 22:17:50 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Dima Dorfman Cc: "Brian F. Feldman" , arch@freebsd.org Subject: Re: MFC'ing xucred definition In-Reply-To: <20011214031351.6D1203E2F@bazooka.trit.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 14 Dec 2001, Dima Dorfman wrote: > > Actually, the one thing I'd like to see before we move forward is a > > standard routine that accepts a ucred, and a *xucred, and fills out the > > xucred using the ucred (preferably, in kern_prot.c). Right now, xucred is > > filled out in various places manually (netinet, socket code, et al). As > > we begin to broaden the scope of xucred (for example, I'd like to push in > > the ruid and rgid), it will make things a lot easier, and also prevent > > more code from knowing much about the innards of ucred. That way, also, > > the version number can be kept in one place. > > I had patches to add this routine (and vice versa, xucred->ucred) > before you added the extra fields to ucred, at which point I dropped it > since it didn't make much sense: Which fields do you copy? Effective, > real, or saved {u,g}ids? It would again make sense if xucred had the > same set of fields as ucred, however. It's always been euid in ucred previously, so I assumed that for version 0 of xucred, only euid and egid (plus additional groups) would be exported. Future versions of xucred (probably version 1, only in -CURRENT) would also be able to export ruid, svuid, rgid, and svgid. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message