From owner-freebsd-stable Wed Dec 19 15:32:35 2001 Delivered-To: freebsd-stable@freebsd.org Received: from white.imgsrc.co.jp (ns.imgsrc.co.jp [210.226.20.2]) by hub.freebsd.org (Postfix) with ESMTP id 9EFC037B405 for ; Wed, 19 Dec 2001 15:32:29 -0800 (PST) Received: from black.imgsrc.co.jp (black.imgsrc.co.jp [2001:218:422:2:206:5bff:fe05:7829]) by white.imgsrc.co.jp (Postfix) with ESMTP id 66EEE24D29 for ; Thu, 20 Dec 2001 08:32:28 +0900 (JST) Received: from waterblue.imgsrc.co.jp (waterblue.imgsrc.co.jp [2001:218:422:2:230:48ff:fe41:161b]) by black.imgsrc.co.jp (Postfix) with ESMTP id A8BEB1E461E for ; Thu, 20 Dec 2001 08:32:27 +0900 (JST) Date: Thu, 20 Dec 2001 08:32:26 +0900 Message-ID: <7mn10ebxbp.wl@waterblue.imgsrc.co.jp> From: Jun Kuriyama To: freebsd-stable@FreeBSD.ORG Subject: Re: if_fxp.c typo? In-Reply-To: <86y9kzqjlr.wl@keiichi01.osaka.iij.ad.jp> References: <86y9kzqjlr.wl@keiichi01.osaka.iij.ad.jp> User-Agent: Wanderlust/2.6.0 (Twist And Shout) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=) APEL/10.3 Emacs/21.1 (i386--freebsd) MULE/5.0 (=?ISO-2022-JP?B?GyRCOC1MWhsoQg==?=) MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=ISO-2022-JP Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I noticed this fixes my problem, but I don't know this patch is logically correct or not. I think we should commit this before 4.5-RELEASE if this is correct way. Can someone comment this? At Thu, 22 Nov 2001 08:47:09 +0000 (UTC), Keiichi SHIMA / 島慶一 wrote: > fxp_stop() of the latest fxp driver do SOFTWARE_RESET when called. > Shouldn't this be SELECTIVE_RESET? > > As I'm not familiar with fxp, would someone check and commit it to the > repositry? The current code clears all the hardware mc filters > already set, as a result, the box can't receive any multicast packets > (this is a serious problem especially when using ipv6). ... > --- orig/if_fxp.c Thu Nov 8 18:30:10 2001 > +++ if_fxp.c Thu Nov 22 17:22:38 2001 > @@ -1429,7 +1429,7 @@ > * Issue software reset, which also unloads the microcode. > */ > sc->flags &= ~FXP_FLAG_UCODE; > - CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SOFTWARE_RESET); > + CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SELECTIVE_RESET); > DELAY(50); > > /* -- Jun Kuriyama // IMG SRC, Inc. // FreeBSD Project To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message