From owner-freebsd-emulation@FreeBSD.ORG Thu Nov 21 19:01:54 2013 Return-Path: Delivered-To: vbox@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 35CB37D; Thu, 21 Nov 2013 19:01:54 +0000 (UTC) Received: from vps.rulingia.com (host-122-100-2-194.octopus.com.au [122.100.2.194]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A54962D54; Thu, 21 Nov 2013 19:01:53 +0000 (UTC) Received: from server.rulingia.com (c220-239-250-249.belrs5.nsw.optusnet.com.au [220.239.250.249]) by vps.rulingia.com (8.14.7/8.14.5) with ESMTP id rALJ1ePJ027854 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Nov 2013 06:01:41 +1100 (EST) (envelope-from peter@rulingia.com) X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.14.7/8.14.7) with ESMTP id rALJ1Zi2051982 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 22 Nov 2013 06:01:35 +1100 (EST) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.14.7/8.14.7/Submit) id rALJ1YPp051980; Fri, 22 Nov 2013 06:01:34 +1100 (EST) (envelope-from peter) Date: Fri, 22 Nov 2013 06:01:34 +1100 From: Peter Jeremy To: Eitan Adler Subject: Re: ports/182468: [patch] lang/gcc builds unrunnable emulators/virtualbox-ose Message-ID: <20131121190133.GA51826@server.rulingia.com> References: <201311131240.rADCe13k071373@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline In-Reply-To: X-PGP-Key: http://www.rulingia.com/keys/peter.pgp User-Agent: Mutt/1.5.21 (2010-09-15) X-Mailman-Approved-At: Thu, 21 Nov 2013 21:46:07 +0000 Cc: Bernhard =?iso-8859-1?Q?Fr=F6hlich?= , vbox@freebsd.org, bug-followup X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 19:01:54 -0000 --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2013-Nov-17 16:32:46 -0500, Eitan Adler wrote: >On Wed, Nov 13, 2013 at 7:40 AM, Bernhard Fr=F6hlich w= rote: >> I think the idea and approach is correct but I went for a slighly more >> conservative >> approach if _GCC_RUNTIME was not set which is true in case base gcc is = used=3D > >This can not possibly be correct as the variable begins with a "_". >The initial proposed patch is also incorrect for a similar reason. >_GCC_RUNTIME is not valid for use in a ports Makefile. I completely agree. As I initially stated, this is solely a work- around for a bug in lang/gcc*. In fact the existing use of _GCC_RUNTIME in bsd.gcc.mk is equally wrong and is also just a work- around for lang/gcc* bugs. >Perhaps it would help if USE_GCC or USES=3Dcompiler exposed a variable >indicating the runtime? This is not correct either. A port using lang/gcc should not need to know about the compiler internals. If code compiled with gcc46 needs to be linked against non-standard libraries then using gcc46 for linking should be sufficient - it shouldn't be necessary to add magic "-Wl,-rpath=3D..." options. (IMO, the whole -L/-rpath approach is broken: The runtime searchpath should default to the linktime searchpath. Unfortunately, fixing that isn't possible). --=20 Peter Jeremy --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iKYEARECAGYFAlKOWI1fFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDBCRjc3QTcyNTg5NEVCRTY0RjREN0VFRUZF OEE0N0JGRjAwRkI4ODcACgkQ/opHv/APuIcR4QCguG7m2cfWIDQ7Rihzecsp53yQ J60An1ZMVu/0W52xOuKz6COp96SYAyfs =49pK -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs--