From owner-svn-src-user@FreeBSD.ORG Mon Dec 2 15:22:41 2013 Return-Path: Delivered-To: svn-src-user@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0C733A3D; Mon, 2 Dec 2013 15:22:41 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 841961C60; Mon, 2 Dec 2013 15:22:39 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id rB2FMbWk054847 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 2 Dec 2013 19:22:37 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id rB2FMb0b054846; Mon, 2 Dec 2013 19:22:37 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 2 Dec 2013 19:22:37 +0400 From: Gleb Smirnoff To: Glen Barber Subject: Re: svn commit: r258848 - user/hrs/releng/release Message-ID: <20131202152237.GK48919@FreeBSD.org> References: <201312021440.rB2EeQa6012210@svn.freebsd.org> <20131202145103.GG1839@glenbarber.us> <20131203.001628.1233827032249325723.hrs@allbsd.org> <20131202152054.GH1839@glenbarber.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131202152054.GH1839@glenbarber.us> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: Hiroki Sato , src-committers@FreeBSD.org, svn-src-user@FreeBSD.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 15:22:41 -0000 On Mon, Dec 02, 2013 at 10:20:54AM -0500, Glen Barber wrote: G> > Everything can be overridden by a configuration file regardless of G> > whether envvars are honored even after this change. What is the G> > problem? I do not see negative effect assuming a conf file is used. G> > G> G> This allows the host environment to accidentally pollute the build if G> something is not set in configuration file and unintentionally set in G> the builder's environment. G> G> It was why I specifically did not allow the environment to affect the G> build process. I'd second on this approach. The fact that builds used to depend on environment was very annoying. One couldn't actually reproduce a problem of his colleague. -- Totus tuus, Glebius.